amem: added other audio format support

This forum is about all development around libVLC.
oviano
Cone that earned his stripes
Cone that earned his stripes
Posts: 120
Joined: 12 Jan 2012 11:12

amem: added other audio format support

Postby oviano » 31 Mar 2019 15:42

Hi

As things stand this plugin forces the S16N format, for reasons I'm not too sure about. There was a TODO comment, so I guess it never got looked at, although it seems quite a trivial change to me.

Anyway, I've modified it to work with any format - after all, surely it's up to the audio setup callback to reject/accept the format it has been passed?

I'm not going to make a git patch on this occasion, it's not my usual development environment so it's fiddly to create these patches and in all honesty I've yet to get any patch accepted (my fault, I'm sure!), but here is a link to the file in case it's of use to anyone. It's from the vlc-3.0 branch, but I shouldn't think it's changed much if at all for 4.0.

https://www.dropbox.com/s/79xiwgdhuvovew0/amem.c?dl=0

Cheers

Oliver

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: amem: added other audio format support

Postby Jean-Baptiste Kempf » 10 Apr 2019 08:52

Can you share a patch?
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

MikOfClassX
Blank Cone
Blank Cone
Posts: 48
Joined: 29 Dec 2018 10:23

Re: amem: added other audio format support

Postby MikOfClassX » 18 Apr 2019 09:24

it seems I spotted the same problem: https://forum.videolan.org/viewtopic.php?f=32&t=147910

Pls submit the patch.


Return to “Development around libVLC”

Who is online

Users browsing this forum: No registered users and 10 guests