Please check modules\video_output\msw\directx.c

This forum is about all development around libVLC.
JoungEunKim
Cone that earned his stripes
Cone that earned his stripes
Posts: 150
Joined: 10 Dec 2009 00:21

Please check modules\video_output\msw\directx.c

Postby JoungEunKim » 30 Oct 2013 12:10

Hi.

I don't know this is fixd.

modules\video_output\msw\directx.c line 1430.

static BOOL WINAPI DirectXEnumCallback2(GUID *guid, LPTSTR desc,
LPTSTR drivername, VOID *data,
HMONITOR hmon)
{
enum_context_t *ctx = data;

VLC_UNUSED(guid); VLC_UNUSED(desc); VLC_UNUSED(hmon);

char *psz_drivername = FromT(drivername);
ctx->values = xrealloc(ctx->values, (ctx->count + 1) * sizeof(char *));
ctx->descs = xrealloc(ctx->descs, (ctx->count + 1) * sizeof(char *));

ctx->values[ctx->count] = psz_drivername; ---> I think psz_drivername is for descs. not values. I recommend strdup(drivername) :)
ctx->descs[ctx->count] = psz_drivername;
ctx->count++;

free(psz_drivername); ---> this is problem. it free in modules\gui\qt4\components\preferences_widgets.cpp
void StringListConfigControl::finish(module_config_t *p_module_config )

return TRUE; /* Keep enumerating */
}

Please check that. :)

Have a nice day.

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: Please check modules\video_output\msw\directx.c

Postby Jean-Baptiste Kempf » 05 Nov 2013 21:02

Yet, it does work.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

JoungEunKim
Cone that earned his stripes
Cone that earned his stripes
Posts: 150
Joined: 10 Dec 2009 00:21

Re: Please check modules\video_output\msw\directx.c

Postby JoungEunKim » 06 Nov 2013 12:29

OK.

Version of Visual Studio, that is problem.

But don't mind. :)


Return to “Development around libVLC”

Who is online

Users browsing this forum: No registered users and 20 guests