New default skin

[3breadt]

I'll need quite more time

Good for me, then I have more time to do the skin

By the way, please, please, use different layouts and not different windows, layout are more efficient and were made for that !!

I'll try, but I made bad experiences with layouts, when I made the iPod Skin I tried to use two layouts, one with a video in the display and the other with the playlist. Didn't work, Playlist and Video were overlaying themselves didnt look good.

Can't you try something like white/aqua for the light version ?

I'll have a look.

[3breadt]

layout are more efficient and were made for that !!

seems that they were not made for being used with videos because that creates a mess.

But see yourself:
http://altglass.al.funpic.de/d-gfx/stuf ... ayouts.vlt

Just change to minimal mode, or resize the Full Layout before switching to the Video Layout.

[3breadt]

I Don't like it, do you?

[dionoea]

Maybe something a bit more blue with a white/blue background gradient like:

[AsMaX]

layout are more efficient and were made for that !!
seems that they were not made for being used with videos because that creates a mess.

Yes, indeed, that's precisely the bug I am supposed to fix, but it doesn't work with different windows either so it is not a reason not to use layouts !!

By the way I found a way to have this working better, but there are still difficult issues to fix (e.g when you switch from a layout to another while playing a video, a new external vout window is created, until you restart the video again). I may commit that in svn trunk soon, but if 0.8.5 has to be released soon I fear to break things just before the release... Maybe if you could do a skin without different video windows it will be ok for 0.8.5, but I prefer to take more time to have things working properly than writing bad hacks at the very last minute.
Another option is to say that even if the new default skin is not perfect, it would still be better than the current one
As we are facing several problems to have a new full-featured default skin, isn't it better to take time to test it, and put it on the site so that users can give feedback ? (even if comments are not implemented, downloads and rating is already a clue of how popular it is).

[3breadt]

Ok, then i'll do the dark-blue and light-black only with Full and Minimal Mode, so that they can be used in 0.8.5. Ok?

[janux]

Not at all. I'm lovin it
This skin rocks.
Yeah, it has a boring look , but that is neutral

I too like the Light Black most.
The default skin should not be to fancy the Light Black is just perfect.

Q: Is it possible to hide the equaliser?
I never use that thing and it's stealing space from the playlist.

I tried testing the skins at
http://altglass.al.funpic.de/d-gfx/stuff/
but i'm getting erros

[3breadt]

with what skin did you get errors, and which errors?

[dionoea]

I too like the Light Black most.
The default skin should not be to fancy the Light Black is just perfect.

A black skin will never make it as a default skin, too many devs object.

[janux]

A black skin will never make it as a default skin, too many devs object.

Thats fine, but somehow I don't like the aqua above

currently i'm using this one:


@aLtgLasS
I took this one:
http://altglass.al.funpic.de/d-gfx/stuff/Default (Dark-Blue).vlt
but on loading i still see the old one

Thats what i get in the message window:

Code: Select all

xml error: XML parser error (line 1) : Document is empty skins2 error: Failed to parse C:\Programme\VideoLAN\VLC\skins\Default (Dark-Blue).vlt skins2 error: A problem occurred when loading the new theme, restoring the previous one

[dionoea]

hehe I'm not saying that aqua/blue is the solution. It was just an idea.

[Khamelion]

A black skin will never make it as a default skin, too many devs object.

Thats fine, but somehow I don't like the aqua above

I don't like it either, it reminds me some kind of bathroom, but I don't know why

@aLtgLasS
I took this one:
http://altglass.al.funpic.de/d-gfx/stuff/Default (Dark-Blue).vlt
but on loading i still see the old one

Is it possible that you're using VlC version 0.8.4?
It doesn't support the new skin funktion. If you want to test it, you must use the test version 0.8.5.

I hope altglass or someone else can solve that bug problem.
But isn't it possible just to use the Video Version and two windows for EQ and Playlist which can be docked ?

[3breadt]

It's hard to please everyone, but I'll try.
So you want only the light skin? Ok you'll only get that.
It will contain one window with buttons and video, one eq window and one playlist window.

That will be the last change in the layout, I'm fed up of all the changes

[3breadt]

I need help!
http://altglass.al.funpic.de/d-gfx/stuff/Default.vlt

When loading it crashes saying Visual C++ Runtime Error, application has requested runtime to terminate in an unusual way etc.

The last things from the Message Log:

skins2 debug: loading font F:\Dokumente und Einstellungen\Daniel\Eigene Dateien\tools\VLC\skins\Default (Light-Black)\Delicious-Roman.otf
skins2 debug: loading font F:\Dokumente und Einstellungen\Daniel\Eigene Dateien\tools\VLC\skins\Default (Light-Black)\Delicious-Roman.otf

The font seems to be ok, and everything worked fine until I added Playlist Window. Help!

[Asim]

hmmph... i tried removing playlist window from ur file... didnt work... same VLC error message... try backtracking to see if there's anything else u might've done apart from playlist?

[3breadt]

Found the error.
It was in the action to show the playlist window. I wrote playlistwin.show();

I am used to add semicolons after all function from javascript but in vlc it causes this crash when no other action follows.

BTW: Feature Request
leftop and rightbottom for anchors so that they move when the window is resized and dont stay at the same place

//Edit:

Default Skin at current state of development:

http://altglass.al.funpic.de/d-gfx/stuff/Default.vlt

To Do:
-Equalizer Window

[Khamelion]

My first expression. AWESOME.
Critics will come soon

[dionoea]

Looks nice

[zorglub]

Hello,

I didn't post in this thread because I just hated the very first versions (blue, orange, ...), but the latest version is really nice.

A few comments and suggestions I have:
- There are too many buttons. I think at least streaming wizard and messages log should go (we could add streaming wizard to the popup menu).
I would personally use this layout for buttons :
[Play] [Playback control] [Open Playlist Equalizer] [File-info Preferences Change-Skin] [Fullscreen Volume]

- The playlist would benefit from an anchor, dunno exactly how and where
- The close and minimize buttons are a bit too small, it's not easy to click them.
- The enabled state for playlist icons should maybe be a bit more different than disabled state, it's a bit hard to say whether it's enabled or not.

Nice work!

[AsMaX]

I'm sad that all the colours have gone... but if that's the only way to please everyone let's keep with that
Just some remarks:
- please use lower case for the font name if you use zip compression, otherwise your skin doesn't work on linux.
- it doesn't appear obvious that the windows are resizable (I first thought they were not...)
- there should be a "down" image for the pause button
Beyond that, it's nice

[Khamelion]

Why is not possible to have a maximize button for skin? Could someone explain that to me?

Well, most of the things has already said.
- Bad, that you can't use the switch button to the minimal version but ok
- Is it normal when I'm resizing the window a "black box" appears?
- Do we really need that change skin button? Normally I always change that in the menu and I don't know any other Player who has that button on their skin.
- The Playlist doesn't dock on that player, only on the "wall" of the Desktop.
- It would be also better if you can make a button which can active and deactivate the playlist and eq.

BUT GOSH. This skin rocks and you gain with your changes more and more fans
It's obviously the best VLC skin so far. Compliment.

[ipkiss]

Found the error.
It was in the action to show the playlist window. I wrote playlistwin.show();

I am used to add semicolons after all function from javascript Sad but in vlc it causes this crash when no other action follows.

Thanks for reporting the problem, I have just fixed it.

BTW: Feature Request
leftop and rightbottom for anchors so that they move when the window is resized and dont stay at the same place

Yes, it should be done, but we have to prevent the case where the anchor is resized (which has no meaning for a pontual anchor). I might have a look at it one of these days.

Default Skin at current state of development:

http://altglass.al.funpic.de/d-gfx/stuff/Default.vlt

A few remarks, in addition to what has already been said:
- A very thin black line around the skin would be nice, because it's not easy to see where it stops, on a white background (in particular on the sides)
- You should allow horizontal resizing of the playlist, because it is not so wide...
- The button showing the playlist should become a checkbox, to allow hiding it and to show visually whether the playlist window is open
- Please put all your files into one directory, inside the zip, it avoids polluting the current directory when extracting
- Apart from that, good work, this is a very nice skin!

[Asim]

hmm just my 2 cents as well:

1. the "glass" shadow in my opinion should be a bit lower... e.g. right in the middle instead of towards the top...

2. teh "play" button shadow is too wavy

3. font should be changed... (pretty hard to read timing)

otherwise... looking nice...

- Asim

[3breadt]

@zorglub:
As the buttons waste no space I won't remove them. It's just easier to access all the function by just clicking rather then searching in the context menu
All Windows will get anchors when they will be movable, because otherwise the windows dont move alongside the others when they are resized and overlap themselves.
Down State of Buttons will be redone.

@AsMaX:
Renamed the font
I added this black bar around the bottom right corner of the video window to indicate resizability.
Pause Images will be added.

@Khamelion
Maximize is not implemented.
Black Box? No.
We do not need it but there would leave free space when removed and that doesnt look sooo good.
As said anchors will be added.
Playlist can be closed. Equalizer not yet done.

@ipkiss
I think I'll add also some gradient black lines to the side like at the top/bottom.
H-Resize? Maybe, I'll have a look.
Checkbox, ok.
Folders? ok.
nice skin? thank you

@@$im
glass shadow? You mean the white transparent overlay at the buttons that creates the glass effect? I have made best experience with this variant, changing it will make the buttons look totally different, so...
play button to wavy? I like it, and it seems that the others like it, too
But the font is so "delicious" I can reed it very good! Need glasses ?
looking nice? 10q!

[zorglub]

As the buttons waste no space I won't remove them. It's just easier to access all the function by just clicking rather then searching in the context menu

Ok, I disagree, but that's your call. Could you at least change the layout. Currently, the second button group is very hard to use if you don't know it perfectly.

My point was actually not about wasted space, but about usability. An interface with 16 buttons is a bit too crowded IMHO