header rename in ffmpeg cvs

[VMiklos]

hi

if you compile ffpmeg from cvs (which is recommended by the ffmpeg team) then the libpostproc headers' location will not be supported by vlc.

also the -lpostproc linker flag is now provided by a separate .pc file

here is a fix:

http://darcs.frugalware.org/repos/fruga ... fmpeg.diff

yes, i know, the header changes are not acceptable, but shows you what is the sollution. i tried to add some elifs, but i've not succeeded

comments?

[The DJ]

Could you please report this to ffmpeg ?
I doubt these changes are intentional, and they will break about every linux distribution package in existence if this is true.
Also, i'm not sure if you are right, since VLC nightly builds install from ffmpeg CVS and there doesn't seem to be an issue there.

Further investigation is required.

[xtophe]

about libpostproc being now in a separate .a|.so|.dll|.dylib and with a .pc, the configure script in SVN already take care of that since 1 week-10 days.

If you have problem with it, it's possible we forget a case, so please precise your problem.

Also about, the header i'll check out ffmpeg cvs sometimes today to have a look.

Do you use make install with ffmpeg or do you use --with-ffmpeg-tree ?

[VMiklos]

i'm using our ffmpeg-20060214 package. i'll ask our ffmpeg maintainer to report this bug (if it is a bug) to the ffmpeg devels

thanks,
VMiklos

--
Developer of Frugalware Linux, to make things frugal - http://frugalware.org

[xtophe]

I have no problem at all with the current CVS.

(and you better chack with the CVS before reporting a bug to ffmpeg because that's the first thing they will answer you)

[voroskoi]

I have no problem at all with the current CVS.

(and you better chack with the CVS before reporting a bug to ffmpeg because that's the first thing they will answer you)

Hi,

I'm the so called ffmpeg maintainer I've tried ffmpeg-20060303.

It still does not work for me: ffmpeg.c:49:44: error: libpostproc/postprocess.h: No such file or directory

So may i ask you to paste here how do you build ffmpeg and vlc to get it work out-of-the-box? IMO you don't install just compile it that's why you haven't encounter our problem. If you do a make install you'll see that libpostprocess.h is in libdir, not in libpostproc directory.

Anyway i'll report it to ffmpeg guys if you confirm that it isn't a fake problem. Thanks in advance!

[The DJ]

Eh i believe the point was that this was fixed in VLC SVN. If ffmpeg changes their API in CVS, you cannot expect an old version of VLC to support that.

[voroskoi]

Eh i believe the point was that this was fixed in VLC SVN. If ffmpeg changes their API in CVS, you cannot expect an old version of VLC to support that.

Sry, i haven't noticed you have fixed it in SVN. That's why i haven't understand you

[Guest]

I have exactly the same problem on both 0.8.4 and 0.8.5. . I found a dirty workarround, but it still can't fully compile. This is what i did: make a new folder in /modules/codec/ffmpeg/ and call it "libpostproc", do the same in /modules/stream_out/. Get ffmpeg source and copy the file postprocess.h into both new folders. Compile.

Well, it seems the source tree is broken. I really don't know if this is either a vlc or ffmpeg problem, but the thing is it's not working out of the box.

[Guest]

Well, it seems i got it working. Download ffpmeg source and ./configure --enable-gpl --enable-pp , make and make install . Then copy the ffmpeg compiled libpostproc from libavcodec (/ffmpeg/libavcodec/libpostproc) to vlc's /modules/codec/ffmpeg and /modules/stream_out , configure, make and make install.

I don't know if needed to copy libpostproc from ffmpeg to vlc, but it worked this way.