make check fails on win32 build

[rolznz]

Hi,
I've built VLC for WIn32 following https://wiki.videolan.org/Win32Compile/ and happily am able to run it and make changes.

I've stashed all my changes and ran:

make
make check

I get the following output:

Code: Select all

Making all in test make[2]: Entering directory '/mnt/c/dev/vlc/win32/test' make[2]: Nothing to be done for 'all'. make[2]: Leaving directory '/mnt/c/dev/vlc/win32/test' make[2]: Entering directory '/mnt/c/dev/vlc/win32' make[2]: Leaving directory '/mnt/c/dev/vlc/win32' make[1]: Leaving directory '/mnt/c/dev/vlc/win32' make check-recursive make[1]: Entering directory '/mnt/c/dev/vlc/win32' Making check in compat make[2]: Entering directory '/mnt/c/dev/vlc/win32/compat' make check-am make[3]: Entering directory '/mnt/c/dev/vlc/win32/compat' make test_strnstr.exe make[4]: Entering directory '/mnt/c/dev/vlc/win32/compat' make[4]: 'test_strnstr.exe' is up to date. make[4]: Leaving directory '/mnt/c/dev/vlc/win32/compat' make check-TESTS make[4]: Entering directory '/mnt/c/dev/vlc/win32/compat' make[5]: Entering directory '/mnt/c/dev/vlc/win32/compat' FAIL: test_strnstr.exe ============================================================================ Testsuite summary for vlc 4.0.0-dev ============================================================================ # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 ============================================================================ See compat/test-suite.log ============================================================================ Makefile:1498: recipe for target 'test-suite.log' failed make[5]: *** [test-suite.log] Error 1 make[5]: Leaving directory '/mnt/c/dev/vlc/win32/compat' Makefile:1604: recipe for target 'check-TESTS' failed make[4]: *** [check-TESTS] Error 2 make[4]: Leaving directory '/mnt/c/dev/vlc/win32/compat' Makefile:1677: recipe for target 'check-am' failed make[3]: *** [check-am] Error 2 make[3]: Leaving directory '/mnt/c/dev/vlc/win32/compat' Makefile:1680: recipe for target 'check' failed make[2]: *** [check] Error 2 make[2]: Leaving directory '/mnt/c/dev/vlc/win32/compat' Makefile:1566: recipe for target 'check-recursive' failed make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory '/mnt/c/dev/vlc/win32' Makefile:2024: recipe for target 'check'

compat/test-suite.log:

Code: Select all

========================================== vlc 4.0.0-dev: compat/test-suite.log ========================================== # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: test_strnstr ================== FAIL test_strnstr.exe (exit status: 53)

I'm not really sure where to go from here if the tests fail on a fresh build.
Can anyone help me out?
In the mean time, is there another way I can ensure my changes don't break anything before submitting a patch? (e.g. running the tests on a unix build instead)

Thanks!

[Jean-Baptiste Kempf]

Read the logs for why strnstr fails.

[Rémi Denis-Courmont]

Note that 'make check' only works and only ever will work for native builds.

[rolznz]

Note that 'make check' only works and only ever will work for native builds.

Thank you!