MIDI demuxer fails to process some odd MIDI files

For questions and discussion that is NOT (I repeat NOT) specific to a certain Operating System.
User avatar
Wohlstand
Blank Cone
Blank Cone
Posts: 16
Joined: 12 Apr 2018 15:57
VLC version: 3.0.9.2
Operating System: Linux Mint 20.1
Location: Moscow, Russia

MIDI demuxer fails to process some odd MIDI files

Postby Wohlstand » 30 Jan 2019 09:22

Hello!
Recently I have got some weird MIDI files are playing fine in some players (as example, my), but won't be played in VLC and won't be opened in MIDI Editors:
https://github.com/Wohlstand/libADLMIDI ... -458643417

The reason of this has been explained here:
The reason for failure: the meta-event Key-Signature needs 2 bytes of payload, these files have 0.

For VLC, it should be requested to implement permissive parsing to bypass such an error. There are just too numerous MIDI files floating around which don't conform.
Sekaiju needs to implement rigourous bounds checking.

Rémi Denis-Courmont
Developer
Developer
Posts: 15312
Joined: 07 Jun 2004 16:01
VLC version: master
Operating System: Linux
Contact:

Re: MIDI demuxer fails to process some odd MIDI files

Postby Rémi Denis-Courmont » 30 Jan 2019 19:59

Sigh. File a bug on Trac with a sample file.
Rémi Denis-Courmont
https://www.remlab.net/
Private messages soliciting support will be systematically discarded

User avatar
Wohlstand
Blank Cone
Blank Cone
Posts: 16
Joined: 12 Apr 2018 15:57
VLC version: 3.0.9.2
Operating System: Linux Mint 20.1
Location: Moscow, Russia

Re: MIDI demuxer fails to process some odd MIDI files

Postby Wohlstand » 31 Jan 2019 09:06

Reported!
https://trac.videolan.org/vlc/ticket/21857
I have attached the ZIP archive that contains those odd MIDI files are can't be played, and I have put log piece that was reported by user of my libADLMIDI plugin.

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: MIDI demuxer fails to process some odd MIDI files

Postby Jean-Baptiste Kempf » 10 Mar 2019 21:47

Fixed for 3.0.7
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.


Return to “General VLC media player Troubleshooting”

Who is online

Users browsing this forum: No registered users and 17 guests