Bug - Audio Device Won't Remember Built-in Ouput (Encoded Output)

[guykuo]

Just noticed that I must manually set audio out device after EVERY launch of VLC back to "Built-in Ouput (Encoded Output)". That's the optical output of my Mac Mini.
Current VLC version 3.04 and the latest nightly builds of VLC all revert to "System Sound Output Device" upon launch.

VLC used to remember the selected audio output device.
This is on Mac Mini 2012 running Macos 10.13.6.

Interestingly, the current VLC builds DO remember the output device on a Macbook Pro which isn't using optical output. VLC does remember "Built-In Output" vs "System Sound Output Device"
It's as though the specific string "Built-in Ouput (Encoded Output)" can't be remembered but "Built-in Output" can be stored.

Went back through many nightly builds to locate when this began happening. Located the last version that properly remembers "Built-in Ouput (Encoded Output)" as the audio output device.
vlc-3.0.2-20180309-0541 remembers the optical output correctly
vlc-3.0.2-20180310-0635 onward fail to remember "Built-in Ouput (Encoded Output)"

This bug was introduced between vlc-3.0.2-20180309-0541 and vlc-3.0.2-20180310-0635

I would file a bug report, but the system won't let me sign in

[guykuo]

Finally realized that bug tracker uses completely different user account system.
No wonder forum credentials didn't work.
Created new account for bug tracker and filed a proper bug report.

[billgates]

Can the vlc team fix this?

[billgates]

Please.....

[unidan]

Hi,

I'll try to take a look but I don't own a mac unfortunately, so I hope the first guess would work.

[billgates]

Hi,

I'll try to take a look but I don't own a mac unfortunately, so I hope the first guess would work.

Thank you I can look at a nightly build if you fix and give feedback

[billgates]

Hi VLC team if you find time this holiday season that would be a nice treat. I would like to use VLC version 3 but cannot until this is fixed

[billgates]

Hi VLC team, if you have time soon can you look at this bug and I am happy to test a nightly build if you can fix. Really I'd like to have the encoded hdmi output selected and kept as saved each time vlc starts. Thank you! Bill

[Gep]

Same problem for me, since some updates of VLC, I need to manually select the device to >>DisplayPort (sortie encodée)<< each time I use it.
This selected device is not recorded, and go back to >>Périphérique audio "System Sound" en sortie<< each time I launch VLC.

MacMini 2018 (Mojave) + VLC 3.0.6 > HDMI > Pionner VSX-921 (5+1 Speakers) > HDMI > Video-Projector
If I don't do that, the Pionner cannot decode DTS Audio.

I tried v3.0.2 with the same result, but v3.0.1 works great
I disabled auto-update in waiting a fix...

[jbrisbin]

Bug #21170 (filed by guykuo) has not been addressed as of version 3.0.6. See https://trac.videolan.org/vlc/ticket/21170

Note that it also fails to save "HDMI (Encoded Output)" when an HDMI device is used as the target for unmangled audio.

[billgates]

Nightly 3.0.7 this bug is still active

Please help me fix so VLC saves HDMI (Encoded Output) as the default output!

[billgates]

With this bug not remembering HDMI encoded output (or any different output according to others) and not using hardware or software acceleration to play large HEVC files I am unable to move from VLC 2.2.8 to VLC 3.X
I downloaded VLC 4.X nightly beta to see and it crashes on exit every time
Guess I will be having to find another player until these 2 big issues for me can be fixed

[ayamov]

just investigated the problem and found a bug in restore audio settings code.
the fix is

Code: Select all

diff --git a/modules/audio_output/auhal.c b/modules/audio_output/auhal.c index b56e609bc3..1a704f18d4 100644 --- a/modules/audio_output/auhal.c +++ b/modules/audio_output/auhal.c @@ -540,6 +540,9 @@ RebuildDeviceList(audio_output_t * p_aout, UInt32 *p_id_exists) CFArrayAppendValue(currentListOfDevices, deviceNumber); CFRelease(deviceNumber); free(psz_encoded_name); + + if (p_id_exists && i_id == i_id_exists) + *p_id_exists = i_id; } // TODO: only register once for each device

[dfuhrmann]

Thanks for your investigation. Would it be ok for you to send a git formatted patch to our developer mailing list at vlc-devel@videolan.org? Then we can review it there and hopefully merge it, with your authorship retained.

[guykuo]

Yes! The fix in nightly build works. No more having to manually set audio output device after every VLC launch.

This fix has made VLC much more pleasant to use with an AV receiver.

[dfuhrmann]

Thanks for your feedback. We will release the fix with version 3.0.9 soon.