Video Adjust functions behaviour changed?

[sherington]

Hello,

Something changed (I don't know when it changed but I tested latest git as of time of writing) that affected how the video adjustment (Hue, Saturation, Brightness, Contrast, Gamma) functions in LibVLC work.

It used to be the case that if you enabled video adjustment via libvlc_video_set_adjust_int with libvlc_adjust_Enable, you could then e.g. have a bunch of sliders for the various adjustment properties and any changes would be applied and visible on the video immediately.

Now, it seems you have to explicitly disable the video adjustment filter then reenable it each time you change a value.

So this works, but it's a bit awkward - is this change in behaviour intended?

[Jean-Baptiste Kempf]

It's not intended. Please file a bug and bisect by trying various versions.

[sherington]

It seems this was indeed intentional, at least according to the commit log in the referenced ticket:

https://trac.videolan.org/vlc/ticket/11750

[Jean-Baptiste Kempf]

Yes, this was fixed in 2.2.0 and 3.0.0

[sherington]

Yes, this was fixed in 2.2.0 and 3.0.0

It is fixed in 2.2.0, I tested at f966a0f.

It does not work in 3.0.0, I tested at 87ed7b3, but it's very early days for 3.0.0 of course.