osd menu: broken shortcuts functionality in the 2.0 branch?

[aegor]

I tried to use the osdmenu filter as sub-source, and found the following problems:
1. when I try to select the menu item with the "menu select" command in rc interface (on a highlighted element message),
i got the error message in log:

Code: Select all

"main osd menu error: option key-play does not refer to an int"

key-play is mapped to this button in osdmenu config file.

Config file made from a template and does not have any particularities.
Also, I don't see any errors from osdmenu config file parser/demultiplexor. All resources is founded and parser module inserted in chain
And, when I enter command "key key-play", all works as it should.

2. When I press the mouse button in any area of the screen, I silently never lead to anything, i.e. does not handle mouse events in the osd_ButtonFind from vlc core.

My command:

Code: Select all

./VLC test.mp4 -vvv --extraintf=rc --sub-source=osdmenu --osdmenu-file="`pwd`/osdmenu/dvd.cfg" --osdmenu-file-path="file://`pwd`/osdmenu/dvd" --rc-fake-tty

My osd menu config:

Code: Select all

dir osdmenu/dvd action key-play (0,0) unselect unselect/barroff.png select selection/play.png pressed selected/play.png end action key-slower (0,0) unselect unselect/barroff.png selected selection/slow.png pressed selected/slow.png end action key-play-pause (0,0) unselect unselect/barroff.png select selection/pause.png pressed selected/pause.png end action key-stop (0,0) unselect unselect/barroff.png select selection/stop.png pressed selected/stop.png end action key-chapter-prev (0,0) unselect unselect/barroff.png select selection/previous.png pressed selected/previous.png end action key-jump-medium (0,0) unselect unselect/barroff.png select selection/bw.png pressed selected/bw.png end action key-jump+medium (0,0) unselect unselect/barroff.png select selection/fw.png pressed selected/fw.png end action key-chapter-next (0,0) unselect unselect/barroff.png select selection/next.png pressed selected/next.png end action key-quit (0,0) unselect unselect/barroff.png select selection/esc.png pressed selected/esc.png end action key-vol-up (0,0) unselect unselect/barroff.png select selection/mute.png pressed selected/mute.png action key-vol-up (480,0) type volume range key-vol-down 3 volume/volume00.png volume/volume01.png volume/volume01.png volume/volume02.png volume/volume02.png volume/volume03.png volume/volume03.png volume/volume04.png volume/volume04.png volume/volume05.png volume/volume05.png end end end

OSD parser log fragment:

Code: Select all

[0x1451488] main osd menu debug: creating access 'file' location='/Users/egor/Projects/vlcstuff/july2012/vlc-2.0/osxbuild/VLC.app/Contents/MacOS/osdmenu/dvd/volume/volume05.png', path='/Users/egor/Projects/vlcstuff/july2012/vlc-2.0/osxbuild/VLC.app/Contents/MacOS/osdmenu/dvd/volume/volume05.png' [0x1189aa8] main access debug: looking for access module: 3 candidates [0x1189aa8] filesystem access debug: opening file `/Users/egor/Projects/vlcstuff/july2012/vlc-2.0/osxbuild/VLC.app/Contents/MacOS/osdmenu/dvd/volume/volume05.png' [0x1189aa8] main access debug: using access module "filesystem" [0x1189aa8] main access debug: TIMER module_need() : 0,426 ms - Total 0,426 ms / 1 intvls (Avg 0,426 ms) [0xdda30a8] main stream debug: Using stream method for AStream* [0xdda30a8] main stream debug: starting pre-buffering [0xdda30a8] main stream debug: received first data after 0 ms [0xdda30a8] main stream debug: pre-buffering done 1024 bytes in 0s - 3076 KiB/s [0x1189aa8] main access debug: removing module "filesystem" [0x1451488] osd_parser osd menu debug: |- range=11, file=file:///Users/egor/Projects/vlcstuff/july2012/vlc-2.0/osxbuild/VLC.app/Contents/MacOS/osdmenu/dvd/volume/volume05.png [0x1451488] main osd menu debug: using osd parser module "osd_parser" [0x1451488] main osd menu debug: TIMER module_need() : 346,045 ms - Total 346,045 ms / 1 intvls (Avg 346,045 ms) [0x944e98] main filter debug: using sub source module "osdmenu" [0x944e98] main filter debug: TIMER module_need() : 347,391 ms - Total 347,391 ms / 1 intvls (Avg 347,391 ms) [0x28c9498] main subpicture debug: Filter 'osdmenu' (0x944e98) appended to chain

[Rémi Denis-Courmont]

osdmenu is buggy and unmaintained.

[aegor]

Thanks, Rémi.
Ask to clarify: This is a buggy plugin "osdmenu" or broken (unmantained) support in vlc core in file src/osd.c and(or) other core infrastructure?
Or are we dealing with (undocumented/proposed) changes in libvlc core?
Finally, if this plugin is "buggy/unmantained" in any case, why is this plug-in is included in the official distribution of vlc 2.0.3 for all platforms and have content in --full-help?

[Rémi Denis-Courmont]

Both OSD menu and OSD core are largelly unmaintained.

[aegor]

Thanks, Remi