vlc-git: live-getaddrinfo.patch fails on latest live555

[andrew46]

Hi,

Building vlc-git on Slackware and I have found that the groupsock/inet.c section of the patch contrib/src/live555/live-getaddrinfo.patch fails with live.2011.11.08.tar.gz. I lack the skill to adjust the patch, is it possible somebody could have a look at this?

Thanks for your trouble,

Andrew

[Rémi Denis-Courmont]

That patch works on the latest live555. You're not using the latest.

[andrew46]

In that case I must be doing something foolish, for which my apologies. I am using this version of live555:

http://www.live555.com/liveMedia/public ... .08.tar.gz

and patch rejects the following section:

Code: Select all

--- groupsock/inet.c 2010-04-09 22:27:39.000000000 +0300 +++ groupsock/inet.c 2010-04-17 20:14:07.000000000 +0300 @@ -83,16 +83,6 @@ #define NULL 0 #endif -#if !defined(VXWORKS) -struct hostent* our_gethostbyname(name) - char* name; -{ - if (!initializeWinsockIfNecessary()) return NULL; - - return (struct hostent*) gethostbyname(name); -} -#endif - #ifndef USE_OUR_RANDOM /* Use the system-supplied "random()" and "srandom()" functions */ #include <stdlib.h>

It has been suggested elsewhere that the problem line may be:

Code: Select all

#ifndef USE_OUR_RANDOM

and certainly altering this line to:

Code: Select all

#ifdef USE_SYSTEM_RANDOM

as suggested by mc4man allows the patch to succeed.

Thanks,

Andrew

[andrew46]

Thanks for the fix Rafaël