soverlay broken after version 0.8.6a?

[gbreal]

I tried to search thread for DVB Teletext Subtitle problems and this was the closest. I'm using Windows version of VLC (vlc-0.9.8a-win32.exe) and put preferred subtitle language under "Subtitles & On Screen Display Settings" as you can see. This selects the one arrow is pointing in the photo when it should select the one below in blue. Could this be corrected somehow in the future releases? The screen capture is from Canal Plus DVB-S transport stream where they use Teletext Subtitles for different languages. Also playback counters doesn't grow in the lower right corner during DVB playback.

http://www.nic.fi/~gabriel2/Teletext_su ... omi%5D.png

http://www.nic.fi/~gabriel2/12-31%2014- ... 20House.ts (15MB)

[VLC_help]

http://trac.videolan.org/vlc/ticket/2451
trac ticket for preferring certain subtitle type.

[wapsi]

Thanks for this patch! I applied it in the newest version of VLC and compiled it. Now DVB-streams' soverlay (with DVB subtitles) works again!

I'm just thinking why don't the main developers of VLC fix this problem? This bug has been in VLC for a year or something?

Think I just found it. That problematic commit seems to disable dvb subtitle processing in sout mode. After I removed that check (see patch below) "burning" dvb subtitles to image work again even with rest of ttxsubs patch still applied.

Hopefully someone with better understanding of C and VLC could take a look at this and make proper fix to implement on next release as now problem has been narrowed to few lines - no need to go thru four months worth of commits anymore.

Code: Select all

--- modules/demux/ts.c.old 2008-12-23 00:59:54.000000000 +0200 +++ modules/demux/ts.c 2008-12-23 01:10:05.000000000 +0200 @@ -3120,10 +3120,6 @@ #ifdef _DVBPSI_DR_59_H_ pid->es->fmt.i_group = p_pmt->i_program_number; - /* In stream output mode, only enable descriptor - * pass-through. */ - if( !p_demux->out->b_sout ) - { uint16_t n, i = 0; dvbpsi_subtitling_dr_t *sub; @@ -3208,13 +3204,7 @@ if( !i ) pid->es->fmt.i_cat = UNKNOWN_ES; - } - else #endif /* _DVBPSI_DR_59_H_ */ - { - pid->es->fmt.subs.dvb.i_id = -1; - pid->es->fmt.psz_description = strdup( "DVB subtitles" ); - } } } }

[Jean-Baptiste Kempf]

Tried with 1.0?

[wapsi]

Tried with 1.0?

Yes, I downloaded VLC via git (March 6th 2009) and compiled it with this patch and its working.

Oh, and it didn't work without the patch.

[dvb-t]

Hi,

I find this patch very interesting - as I am using VLC to reencoder TS streams (recorded from my DVB-T usb stick) - So far I have only been able to use version 0.8.6a as I need the subtitles to be working.

I am using Windows, so I followed this guide: http://wiki.videolan.org/Win32CompileCygwinNew - and was able to compile a version 1.0.0 of VLC.

BUT - I cannot figure out how to apply the patch to the current code (1.0.0)- as it (ts.c) has changed a lot. So I tried to download the source for 0.9.8a - but cannot get the code compiled (tried with different contribs' etc) - until 2 o'clock this morning

SO please - if one of you have some spare time - could you compile a windows version (preferable .0.9.6 or .0.9.8a) with the patch applied for me - and make it available for me (either by download/ftp/mail) and I will thankful for ever

Best regards

Anders

[wapsi]

BUT - I cannot figure out how to apply the patch to the current code (1.0.0)- as it (ts.c) has changed a lot. So I tried to download the source for 0.9.8a - but cannot get the code compiled (tried with different contribs' etc) - until 2 o'clock this morning

The patch file didn't work for me either so I opened the patch file with some text editor and manually removed lines to be removed and added lines to be added...

[geerten]

I'm trying to convert .ts files from my Humax decoder/recorder. Depending on the channel they may contain subtitles in dvbs-format or teletext (or sometimes both). Based on this thread I reverted to 0.8.6a, and was able to overlay the dvbs subtitles. But with that version I cannot even display teletext subtitles, let alone overlay them. With the latest version I can display them (and dvbs too), and based on what I read in this thread I should be able to overlay them as well, but I just cannot figure out how. In the subtitles panel there is one checkbox to include subtitles, one checkbox to overlay them into the video, and one listbox, presumably to select which subtitle you want, but it's always empty. I've also tried manually adding some options to the command line below, but so far I haven't found the right incantation.
I would really appreciate a version that handles both types of subtitles, but i'm afraid patching and compiling my own is beyond me.

[VLC_help]

AFAIK you cannot Overlay any text to encoded video using new VLC versions because of this bug.

[wapsi]

When this bug will be repared? I really need 'soverlay' when I'm streaming & transcoding videos over lan/net.

Now I have to use an old version of VLC and compile it manually with the patch which I downloaded from this thread.

[VLC_help]

When this bug will be repared?

When someone sends working patch to mailinglist and someone merges it.

[PeterBak]

I posted this to the list: http://mailman.videolan.org/pipermail/v ... 70772.html. It seems to fix the problem and another related problem that causes subtitles to be out-of-sync when transcoding. Note that it may break other things though. Though this is in the Windows category, i believe this problem is not Windows-specific. I have seen it at least also on Linux and OSX as far as I can tell, although I have only been able to find a Windows version of 0.8.6a.

Hope this helps.

[VLC_help]

Thanks.

[jmetsako]

Just tested VLC v1.1.0 pre3. Soverlay still not working...

[VLC_help]

AFAIK it didn't get commited.
http://mailman.videolan.org/pipermail/v ... 70775.html

[jmetsako]

Just sended this: http://mailman.videolan.org/pipermail/v ... 74910.html

Here is test file http://www.megaupload.com/?d=KGZZLOWZ

Subtitles can be shown with: "C:\Program Files (x86)\VideoLAN\VLC\vlc" tintti.rec --sub-language fi

[jmetsako]

Works now! example:
vlc -Idummy tintti.rec --sub-language fin :sout="#transcode{soverlay,vcodec=h264}:file{dst=testifile.mp4}" vlc://quit

Tested with vlc-1.1.0-rc-20100512-0202 and vlc-1.2.0-git-20100508-0002

Thank's to everyone who have been helpping with this topic!