Simple "File Open" with a Skin on my VLC?

About usage, announcement and development of skins for VLC
Drachenstein
New Cone
New Cone
Posts: 4
Joined: 10 Dec 2009 00:04
Operating System: Windows

Simple "File Open" with a Skin on my VLC?

Postby Drachenstein » 10 Dec 2009 00:17

Hi there

When I use skins with my VLC the menu item of a simple "file open" seems to be missing. There's only "Open Media" which I don't like because it needs more clicks to open a file. Without a skin this menu option is available.

Is this a normal behaviour with skins or am I doing somethin wrong? Can I add this command in an existing skin with a skin editor?

I use the skin "WMP11" from the videolan.org page (http://www1.videolan.org/vlc/download-s ... =WMP11.vlt)

Thanks for any hints!

Wolfgang

3breadt
Big Cone-huna
Big Cone-huna
Posts: 827
Joined: 19 Mar 2006 11:37
Operating System: Win7 Pro / OS X 10.7
Location: Paderborn, Germany
Contact:

Re: Simple "File Open" with a Skin on my VLC?

Postby 3breadt » 10 Dec 2009 13:43

There is an action available in skins2 to do so, you can change skins to use it with the skin editor.

Open the skin, locate the open button and change its action to dialogs.fileSimple().
-- 3breadt (aka altglass)

Drachenstein
New Cone
New Cone
Posts: 4
Joined: 10 Dec 2009 00:04
Operating System: Windows

Re: Simple "File Open" with a Skin on my VLC?

Postby Drachenstein » 10 Dec 2009 15:24

There is an action available in skins2 to do so, you can change skins to use it with the skin editor.

Open the skin, locate the open button and change its action to dialogs.fileSimple().
Cool, that's really easy - thanks for the hint!

I used VLC Skin Editor 0.8.6dev to do so and I tested it with a new button that only would quickly open a file. But I'm confused, it looks like the behaviour of the two commands

- dialogs.fileSimple()
- dialogs.file()

both do open this unwanted "Open Media" Window with all the tabs for "File", "Volume", "Network" and so on.

Any idea what could be wrong?

Thanks - Wolfgang

3breadt
Big Cone-huna
Big Cone-huna
Posts: 827
Joined: 19 Mar 2006 11:37
Operating System: Win7 Pro / OS X 10.7
Location: Paderborn, Germany
Contact:

Re: Simple "File Open" with a Skin on my VLC?

Postby 3breadt » 10 Dec 2009 17:58

Really?
That's strange. Maybe one of the devs has an idea, normally dialogs.fileSimple() should only open the simple "open file" dialog according to the documentation. Maybe its not properly implemented in the skins system.
Or I'm misunderstanding the meaning of "simple open file dialog" :D
-- 3breadt (aka altglass)

erwan10
Developer
Developer
Posts: 415
Joined: 02 Nov 2008 23:16

Re: Simple "File Open" with a Skin on my VLC?

Postby erwan10 » 10 Dec 2009 18:30

Yes, it's weird, and the culprit seems to be the qt4 dialog provider :

Code: Select all

in modules/gui/qt4/dialogs_provider.cpp : switch( de->i_dialog ) { case INTF_DIALOG_FILE_SIMPLE: case INTF_DIALOG_FILE: openDialog(); break; case INTF_DIALOG_FILE_GENERIC:
fileSimple() and file() actually end up executing the same code. Any reason for that ?

Erwan10

3breadt
Big Cone-huna
Big Cone-huna
Posts: 827
Joined: 19 Mar 2006 11:37
Operating System: Win7 Pro / OS X 10.7
Location: Paderborn, Germany
Contact:

Re: Simple "File Open" with a Skin on my VLC?

Postby 3breadt » 10 Dec 2009 22:31

Bug?
-- 3breadt (aka altglass)

Drachenstein
New Cone
New Cone
Posts: 4
Joined: 10 Dec 2009 00:04
Operating System: Windows

Re: Simple "File Open" with a Skin on my VLC?

Postby Drachenstein » 10 Dec 2009 23:39

What a pitty!

I installed WIndows 7 and I'm so sad because Windows Media Player 11 (from Vista) was so beautiful and now I lost it: with Windows 7 the Windows Media Player 12 looks ugly.

I thought I'm clever and I take VLC with the WMP11 skin - and now I can't even open a file (in a simple way) :shock:

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: Simple "File Open" with a Skin on my VLC?

Postby Jean-Baptiste Kempf » 11 Dec 2009 08:46

Yes, it's weird, and the culprit seems to be the qt4 dialog provider :

Code: Select all

in modules/gui/qt4/dialogs_provider.cpp : switch( de->i_dialog ) { case INTF_DIALOG_FILE_SIMPLE: case INTF_DIALOG_FILE: openDialog(); break; case INTF_DIALOG_FILE_GENERIC:
fileSimple() and file() actually end up executing the same code. Any reason for that ?

Erwan10
Stupidity from my part?

It needs fixing for a future version :D
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: Simple "File Open" with a Skin on my VLC?

Postby Jean-Baptiste Kempf » 11 Dec 2009 08:47

What a pitty!
It will be fixed in a future version of VLC.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

Drachenstein
New Cone
New Cone
Posts: 4
Joined: 10 Dec 2009 00:04
Operating System: Windows

Re: Simple "File Open" with a Skin on my VLC?

Postby Drachenstein » 11 Dec 2009 16:03

Yuppieee!


Return to “Skins”

Who is online

Users browsing this forum: No registered users and 7 guests