Automatic deinterlacing for interlaced videos,yadiff filter.

Feature requests for VLC.
kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 01 Sep 2009 18:45

Feature Request: Is it possible for VLC to automatically detect interlacing in mpg/vob videos, and apply a deinterlacing filter? Mplayer can tell between interlaced and progressive videos, Media Player Classic can, DGindex can, Gspot most definately can. Here is Gspot succesfully detecting a progressive mpg from an interlaced mpg, for example:
Image Image
When tried with MPC, it also did an automatic deinterlace, no combing apparent during playback.

If mpg streams don't have interlacing infos, like it has previously been mentioned in this forum, how can all these programs tell? In fact, most of these are freeware utils, so the code is there and waiting to be ported to VLC. What is taking so long?

Back in VLC, I have my preferences -> video -> deinterlace mode set alright. I went to "filters" and the "deinterlace filter" is also set alright. Nope, VLC still fails to detect the interlacing on the video. Then, I tried to brute force my way into the problem by pernamently enabling the deinterlace filter. Nope. Everytime I want to view something interlaced, I have to do blend manually during playback (if I stop the video and start again, it loses the setting)

While VLC handles progressive vids better than anything else, if you have a large collection of TV capture orientered material, this is a real pain to watch it with VLC.

Also, there is a nice yadiff filter in MPlayer, and works much better than blend, so it would be nice to be ported to VLC too.

Thanks,
kurkosdr

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 02 Sep 2009 18:40

Open source sucks.

If it wasn't for VLC being the only player to allow disabling the YUY->RGB hardware conversions, which is the only way of getting decent quality of my mobility X1600 (when they are enabled, I get RGB16-235 instead of the whole range), I would long have moved to PowerDVD...

Which bring the other question: Any player other than VLC that always disabling the YUY->RGB hardware thing?

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby VLC_help » 02 Sep 2009 20:36

Any player other than VLC that always disabling the YUY->RGB hardware thing?
Using OpenGL video output shouldn't have this issue (or other outputs that don't use hardware conversions).

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 03 Sep 2009 02:33

Sorry for the previous post, but seriously, are we going to get that simple but much-wanted feature sometime in the future?

It should be a matter of two lines of code for you. Just check if the mpg is interlaced, and do blend. You can easily obtain the relevant code from DGindex, gspot or mpc. You don't even have to have it on by default (if that aggravates the purists), just put a "detect interlacing and do automatic deinterlace" option in Video preferrences, so people can enable it from there.

I just want to know why it can't be done.

It's a small omission, but it's really a pain if you have lot's of TV and tape originated content.
Last edited by kurkosdr on 03 Sep 2009 07:00, edited 1 time in total.

nikola23
Cone that earned his stripes
Cone that earned his stripes
Posts: 115
Joined: 03 Feb 2009 07:25
VLC version: 1.2 pre3
Operating System: Win7\Ubuntu 10.10

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby nikola23 » 03 Sep 2009 06:36

I'd love to see this feature... However I'm sure it isn't trivial as you act like it is, or it probably would have been done already.

Ezza
New Cone
New Cone
Posts: 3
Joined: 02 Sep 2009 14:16

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby Ezza » 03 Sep 2009 17:42

yes it would be awesome to have this feature, its a total pain to do it manually

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 07 Sep 2009 14:48

Are we going to get it? Someone from the project please answer...

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby VLC_help » 08 Sep 2009 14:13

I haven't heard any news about this.

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 10 Sep 2009 11:45

I haven't heard any news about this.
Well, can it be added in the group's "to do" list somehow?

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby VLC_help » 11 Sep 2009 15:27

Well, can it be added in the group's "to do" list somehow?
There isn't list like that. Devs mostly do features that they like/need or what someone has paid them to do.

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 22 Sep 2009 11:43

Well, can it be added in the group's "to do" list somehow?
There isn't list like that. Devs mostly do features that they like/need or what someone has paid them to do.
If nobody takes into account the things we say, what is the point of calling it a "feature request" forum? I propose calling it the "features you want and never gonna see implemented" forum. Also, there is a TRAC to implement Yadif on to VLC (but TRAC is down, sigh).

I think it's not the automatic interlace detection that's bothering most users, we have gspot for that(right?). I think it's mostly the sub-par filters VLC is offering. You have to choose between blur in motion (blend), drop odd frames, and flicker in static pictures. Yadif offers the best de-interlace, ever. Since Yadif is opensource, it shouldn't be that hard to implement . This isn't gonna make VLC friendly if it still lacks auto detection, but at least it's gonna justify the absolute playback quality it once stood for.

VLC = YAOSPTS (aka Yet Another Open Source Project That Stagnated)

Media Player Classic Home Cinema = See you There, You Will Have To Learn This From Scratch Again. But this I guess this is how opensource rolls.

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby VLC_help » 22 Sep 2009 13:44

If nobody takes into account the things we say, what is the point of calling it a "feature request" forum?
It is easier to have one subforum for request than flood all other subforums with posts. And some request seen in here are going to be implemented to VLC so this isn't a completely useless place.
Also, there is a TRAC to implement Yadif on to VLC
trac-test.videolan.org/vlc/ticket/2874
and forum method also applies to tickets. So they are fixed or implement if someone wants to do them (security errors are exception).

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 23 Sep 2009 13:46

So they are fixed or implement if someone wants to do them (security errors are exception).
This is what puzzles me. How it's possible nobody of the team not to want yadif on VLC?? Even the lamest shareware out there has some short of advanced de-interlacing filter, and PowerDVD had yadif-like filters since it's first versions.However, VLC is stuck with the same old sub-par filters of the past decade...

I wish I could contribute to this, but I don't know what to start learning.

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby Jean-Baptiste Kempf » 24 Sep 2009 00:05

yadif is necessary to VLC. But noone had time to do the correct code filter...
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 24 Sep 2009 17:10

yadif is necessary to VLC. But noone had time to do the correct code filter...
But the code is open source and freely available on mplayer's source code. All that's needed is a copy paste and some renaming, right?

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby Jean-Baptiste Kempf » 25 Sep 2009 16:23

haha. Very funny.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 27 Sep 2009 21:21

Yes, I oversimplified in my previous post, but this is the way things are.

The VLC team has devoted hours and hours of work into adding support for non-existent closed source formats like realmedia (what was the last time you saw one without a mov or wmv version nearby?) and the like, yet the inclusion of a proper de-interlace filter to deinterlace videos from the omni-present DVD video discs is considered an unimportant and low-priority task. W, T and F?

Yadif is opensource, which, according to the opensource philoshopy, it was supposed to be able to be ported into other opensource projects rather easily. And/or anyone should be able to understand how it works and make a similar filter. Is the addition of one more opensource filter so hard for the VLC team? I want to think no.

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby Jean-Baptiste Kempf » 27 Sep 2009 21:30

People work on what they want, not on what other people want them to work on.
If you need it that hard, please help and send a patch.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 28 Sep 2009 16:26

Where can I start to learn how to code for the videolan team? Some books or wikis out there I could read?

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby Jean-Baptiste Kempf » 28 Sep 2009 19:03

Any C manual. And some asm for yadif. :D
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby VLC_help » 29 Sep 2009 14:01

http://wiki.videolan.org/Developers_Corner
that might also be helpful.


VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby VLC_help » 05 Oct 2009 13:34

Any player other than VLC that always disabling the YUY->RGB hardware thing?
Mplayer can do that.

kurkosdr
Cone that earned his stripes
Cone that earned his stripes
Posts: 101
Joined: 14 Jun 2009 00:36

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby kurkosdr » 06 Oct 2009 18:10

Thank you! Does this mean yadif will be present on VLC 1.03?

I agree, I could use Mplayer, but it's to Linux-y, Windows support is not their first priority, so VLC seems better for us Windows users (even Miro prefers VLC for it's windows build)

PS: If Seven has the same wrong YUY->RGB conversions like Vista (ms ordered it to be studio rgb instead of computer rgb), I will probably be sticking to VLC for a couple of years. MS added the option to set the RGB conversions to their correct setting, but only for HDMI monitors not DVI/laptop ones (so that they won't lose their htpc market, but I guess there is no need for ms to care about us pc users :? ). That's why I am so glad to see Yadif on VLC, as WMP/PowerDVD will probably be useless on Seven, like now on Vista...

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: Automatic deinterlacing for interlaced videos,yadiff filter.

Postby Jean-Baptiste Kempf » 06 Oct 2009 18:45

And automatic detection of deinterlacing is on its way into VLC in the next days.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.


Return to “VLC media player Feature Requests”

Who is online

Users browsing this forum: No registered users and 26 guests