7.1 default (if ac3 available with 5.1) == 5.1

Feature requests for VLC.
crazyV
New Cone
New Cone
Posts: 1
Joined: 06 Dec 2007 13:45

7.1 default (if ac3 available with 5.1) == 5.1

Postby crazyV » 06 Dec 2007 14:01

Hi!
At first :=) very nice work done with this player :=)
works great, plays everything ;) hardly ;)

I have a 7.1 Surround System and like to see movies and serie with ac3 surround sound.
My windows configuration is: 7.1 Surround Sound

The "problem": VLC doesn't recognize that i have a 7.1 sound system and so the active audio output for ac3 files is "Stereo"
It would be very, very great if it would be like that: when there are more "boxes/speakers" than 5.1 (example 7.1, like mine) make 5.1 default.

Because if you change your settings in windows to 5.1 VLC does recognize that you have a 5.1 system, and also enables 5.1 surround sound in the movie (ac3 sound).
There has to be a small if statement somewhere in the code ;=)

Thanks for a nice free player!
keep on doing such great work :)

greets,
crazyV

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby VLC_help » 08 Dec 2007 00:37

My educated guess is that DSSPEAKER_5POINT1 is in VLC, but DSSPEAKER_7POINT1 isn't =)
So adding
#define DSSPEAKER_7POINT1 0x00000007
to modules/audio_output/directx.c might do the trick.

Also DSSPEAKER_DIRECTOUT is missing... anything to do with bad SPDIF support?
#define DSSPEAKER_DIRECTOUT 0x00000000

http://msdn2.microsoft.com/en-us/library/aa390684.aspx

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby Jean-Baptiste Kempf » 08 Dec 2007 05:32

What about providing a patch ?
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby VLC_help » 09 Dec 2007 12:10

If you refer to me, I don't have 5.1 or 7.1 output for testing the patch nor compiling environment to set up for the job =)

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby VLC_help » 27 Mar 2008 23:06

Now I have compiling environment but not the equipment, so if someone has 7.1 output and wants to try playback multichannel audio http://www.megaupload.com/?d=Q7XDY59B there is 0.9.0 build which should work better. Please report any findings to this thread.

dany_be
New Cone
New Cone
Posts: 5
Joined: 01 Apr 2008 04:43

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby dany_be » 01 Apr 2008 04:58

I tried playback with 0.9.0 and the default is still Stereo and not 5.1.

I have the same problem.
Even if I make a playlist and set all mediafiles manually to 5.1 and if i switch the files in playlist, the setting on audiodevice is gone to Stereo instead of keeping 5.1.
Manual setting to 5.1 works of course, but if you play the next file or restart the player, the device is changed to Stereo.
This is very annoying, if you lay in bad, watching your favorites mediafiles and u have to stand up for every playlistentry...

System
Vista 64
X-Fi
Windows-Settings on 7.1
Creative-Settings on 7.1
VLC 0.8.6e and tested with 0.9.0

Greetins and thanks

p.s. is there a possibility to add #define DSSPEAKER_7POINT1 0x00000007 to any configurationfile (binary version, not the sourcefiles, i'm not a developer :) ?

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby VLC_help » 01 Apr 2008 17:03

It (DSSPEAKER_7POINT1) is a sourcecode level thing. dany_be: could you open View -> Messages before playback, open some audio file and see if log displays aout_directx debug: device supports lines, paste those lines here, please.

dany_be
New Cone
New Cone
Posts: 5
Joined: 01 Apr 2008 04:43

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby dany_be » 01 Apr 2008 18:26

0.8.6e
aout_directx debug: device supports 5.1 channels
aout_directx debug: device supports 4 channels
aout_directx debug: device supports 2 channels
aout_directx debug: device supports 1 channel

0.9.0.
aout_directx debug: device supports 5.1 channels
aout_directx debug: device supports 4 channels
aout_directx debug: device supports 2 channels
aout_directx debug: device supports 1 channel

Code: Select all

0.8.6e a52: A/52 channels:6 samplerate:48000 bitrate:384000 aout_directx debug: OpenAudio aout_directx debug: aout_directx debug: found device: Lautsprecher (Creative SB X-Fi) aout_directx debug: aout_directx debug: found device: SPDIF Out (Creative SB X-Fi) aout_directx debug: main debug: no usable vout present, spawning one main debug: window size: 512x384 main debug: looking for video output module: 6 candidates main debug: Registering subpicture channel, ID: 2 main debug: Registering subpicture channel, ID: 3 main debug: Registering subpicture channel, ID: 4 main debug: Registering subpicture channel, ID: 5 aout_directx debug: device supports 5.1 channels aout_directx debug: device supports 4 channels aout_directx debug: device supports 2 channels aout_directx debug: device supports 1 channel aout_directx debug: creating DirectSoundThread main debug: thread 4632 (DirectSound Notification Thread) created at priority 15 (directx.c:372) main debug: using audio output module "aout_directx" aout_directx debug: DirectSoundThread ready main debug: output 's16l' 48000 Hz Stereo frame=1 samples/4 bytes main debug: mixer 'fl32' 48000 Hz Stereo frame=1 samples/8 bytes main debug: filter(s) 'fl32'->'s16l' 48000 Hz->48000 Hz Stereo->Stereo main debug: looking for audio filter module: 24 candidates main debug: using audio filter module "float32tos16" main debug: found a filter for the whole conversion main debug: looking for audio mixer module: 3 candidates main debug: using audio mixer module "float32_mixer" main debug: input 'a52 ' 48000 Hz 3F2R/LFE frame=1536 samples/1536 bytes main debug: filter(s) 'a52 '->'fl32' 48000 Hz->48000 Hz 3F2R/LFE->Stereo main debug: looking for audio filter module: 24 candidates main debug: using audio filter module "a52tofloat32" main debug: found a filter for the whole conversion main debug: filter(s) 'fl32'->'fl32' 52800 Hz->48000 Hz Stereo->Stereo main debug: looking for audio filter module: 24 candidates main debug: using audio filter module "bandlimited_resampler" main debug: found a filter for the whole conversion 0.9.0. a52 info: A/52 channels:6 samplerate:48000 bitrate:384000 main debug: looking for audio output module: 4 candidates aout_directx debug: OpenAudio aout_directx debug: found device: Prim?rer Soundtreiber aout_directx debug: found device: Lautsprecher (Creative SB X-Fi) aout_directx debug: found device: Digitales Ausgabeger?t (SPDIF) (High Definition Audio-Ger?t) aout_directx debug: found device: SPDIF Out (Creative SB X-Fi) aout_directx debug: found device: Kopfh?rer (High Definition Audio-Ger?t) aout_directx debug: device supports 5.1 channels aout_directx debug: device supports 4 channels aout_directx debug: device supports 2 channels aout_directx debug: device supports 1 channel aout_directx debug: creating DirectSoundThread main debug: thread 9628 (DirectSound Notification Thread) created at priority 15 (directx.c:373) main debug: using audio output module "aout_directx" main debug: output 's16l' 48000 Hz Stereo frame=1 samples/4 bytes main debug: mixer 'fl32' 48000 Hz Stereo frame=1 samples/8 bytes main debug: filter(s) 'fl32'->'s16l' 48000 Hz->48000 Hz Stereo->Stereo aout_directx debug: DirectSoundThread ready main debug: looking for audio filter module: 24 candidates main debug: using audio filter module "converter_float" main debug: found a filter for the whole conversion main debug: looking for audio mixer module: 3 candidates main debug: using audio mixer module "float32_mixer" main debug: input 'a52 ' 48000 Hz 3F2R/LFE frame=1536 samples/1536 bytes main debug: filter(s) 'a52 '->'fl32' 48000 Hz->48000 Hz 3F2R/LFE->Stereo main debug: looking for audio filter module: 24 candidates main debug: using audio filter module "a52tofloat32" main debug: found a filter for the whole conversion main debug: filter(s) 'fl32'->'fl32' 52800 Hz->48000 Hz Stereo->Stereo main debug: looking for audio filter module: 24 candidates main debug: using audio filter module "bandlimited_resampler" main debug: found a filter for the whole conversion
I played a mediafile with Dolby Surround today and there was the default on Dolby Surround an not Stereo *confused*

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby VLC_help » 02 Apr 2008 17:58

There might be an issue with dwChannelMask. I will check it out on friday and paste a new build if you want to test it.
(rest of the post is meant for me)
http://msdn2.microsoft.com/en-us/library/ms791058.aspx
http://66.102.9.104/search?q=cache:ApxO ... nt=mozilla
http://www.krugle.org/examples/p-sZVbRn ... format.cpp
http://www.microsoft.com/whdc/device/au ... chaud.mspx

dany_be
New Cone
New Cone
Posts: 5
Joined: 01 Apr 2008 04:43

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby dany_be » 02 Apr 2008 21:50

thanks a lot, i will help where i can :)
(don´t know, if this idiom makes in english any sense ^^)

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby VLC_help » 05 Apr 2008 14:23

:oops: I totally forgot VLC_VAR_SETDEFAULT and GetSpeakerConfig. My bad (so my previous post is wrong). I have now new build which won't set Stereo as default if there are 5.1 or 7.1 sounds (unless SpeakerConfig defaults to stereo) and it will also tell what Windows tells about SpeakerConfig. So if it still defaults to Stereo, please check the log for line Windows says your SpeakerConfig is and see if it identifies you setup correctly. I could add option to override setup given by Windows if people want/need it.

http://www.megaupload.com/?d=8Y796BPU

dany_be
New Cone
New Cone
Posts: 5
Joined: 01 Apr 2008 04:43

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby dany_be » 16 Apr 2008 15:06

the log doesn´t tell, what "Windows says your SpeakerConfig is" on verbose level 2.
with directx output it still doesn´t work.

i figured out, if i change audio output from directx to Win32 waveout extension it works and standard audio device is 5.1 if available :-)
works with your new version and also with the old ones.

do i have any disadvantage choosing wav32 instead directx?

VLC_help
Mega Cone Master
Mega Cone Master
Posts: 25661
Joined: 13 Sep 2006 14:16

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby VLC_help » 17 Apr 2008 21:54

Little higher CPU usage with Waveout usually, but difference is very small.

dany_be
New Cone
New Cone
Posts: 5
Joined: 01 Apr 2008 04:43

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby dany_be » 18 Apr 2008 00:55

Great!

so many thx for your help! :)

Jizah
New Cone
New Cone
Posts: 2
Joined: 07 Apr 2007 23:26

Re: 7.1 default (if ac3 available with 5.1) == 5.1

Postby Jizah » 26 Apr 2008 01:17

This has been bugging me for ages. I actually resorted to just setting my entire system to 5.1 permanently and had 2 speakers doing nothing. Now I can use all 7 again! So thanks heaps for this.


Return to “VLC media player Feature Requests”

Who is online

Users browsing this forum: No registered users and 11 guests