change logo function did not work when streaming(rtsp)

[smartstone]

I have tried the nighty build and 0.9.8a release version. all have the same issue.
version: 0.9.8a
platform: fodora 10
plug-in: ffmpeg

I run following code on server:

vlc -I rc --logo-file logo.png -vvvv v4l2:///dev/video0 --sout '#transcode{width=320,height=240,vcodec=mp4v,vb=768,venc=ffmpeg{keyint=8,hurry-up,vt=800000},deinterlace,sfilter=logo}:rtp{dst=172.22.1.10,port=1234,sdp=rtsp://172.22.1.10:8090/test.sdp}' --ttl 12

on the client side:
quicktime play rtsp://172.22.1.10:8090/test.sdp

--------------------------------------------------------------------------------------
on server side console, I CAN do @logo logo-x @logo logo-transparency @logo logo-position
BUT when I run @logo logo-file abc.png. it will give me the error:
Variable doesn't exist or isn't a command.
I tried to go through the code but somehow lost.

----------------------------------------------
I downgrade the version to 0.8.6, the "logo-file abc.png" work fine. but since it have some issue with ffmpeg and v4l2 device. so it is not a option for me.

please take a look the code, if the developer is busy, give me some clues --which files/functions handle it, so I can make a quick/dirty fix locally.
thanks a lot.

[smartstone]

problem solved by modify the codes in image.c and logo.c

now I can change the logo on fly while streaming but only work with png format logo file .

[tamiro44]

smartstone,
How can i change titles (not logo) on the fly?

Thanks.

[tamiro44]

What is that link??

[clemchen]

I would be interested in a fix for the logo change on the fly, how did you do that ?
Thanks

[clemchen]

I did find a fix, but I don't know if it is really stable, still if someone is interested, here it is :
in logo.c, I replaced the line " add_file( CFG_PREFIX "file", NULL, NULL, FILE_TEXT, FILE_LONGTEXT, false )" by : " add_string( CFG_PREFIX "file", NULL, NULL, FILE_TEXT, FILE_LONGTEXT, false )".
This way, in variable.c, the type return by var_Type is OK (the "i_type&VLC_VAR_ISCOMMAND" test passes, which was not the case before the change, even if the class was OK...).

If you find a problem with this fix, please tell me

[smartstone]

Actually, Clem, you are pretty close. the only change need in logo.c is what you did.
and in image.c (src\misc) in the function ImageRead()

---------comment the following code
#if 0
/* Check if we need chroma conversion or resizing */
if( p_image->p_dec->fmt_out.video.i_chroma != p_fmt_out->i_chroma ||
p_image->p_dec->fmt_out.video.i_width != p_fmt_out->i_width ||
p_image->p_dec->fmt_out.video.i_height != p_fmt_out->i_height )
{
......
}
else *p_fmt_out = p_image->p_dec->fmt_out.video;
#endif
--------add those
*p_fmt_out = p_image->p_dec->fmt_out.video;
p_pic->format = p_image->p_dec->fmt_out.video;

[ktsaou]

I did find a fix, but I don't know if it is really stable, still if someone is interested, here it is :
in logo.c, I replaced the line " add_file( CFG_PREFIX "file", NULL, NULL, FILE_TEXT, FILE_LONGTEXT, false )" by : " add_string( CFG_PREFIX "file", NULL, NULL, FILE_TEXT, FILE_LONGTEXT, false )".
This way, in variable.c, the type return by var_Type is OK (the "i_type&VLC_VAR_ISCOMMAND" test passes, which was not the case before the change, even if the class was OK...).

If you find a problem with this fix, please tell me

For me, this has worked perfectly for vlc 0.9.9a and 1.0.2.

Thanks!

[maitrepiet]

Hi does this mean I would have to recompile the code to use this fix.
I really need to be able to change the logo file dynamically.

[ktsaou]

Yes. I use gentoo, so this is the standard way of doing things...
On other distributions, I suggest to find a good how-to somewhere for your distribution, since such applications tend to have somewhat complicated compilation procedures (lots of dependencies, etc).