Page 1 of 1

VLCAudio class support

Posted: 01 Sep 2015 20:46
by pvms78
Hi,

Could you consider returning, in master branch, the VLCAudio support? I am developing an application with multiple videos with audio and I want to play the audio of the one that is currently selected. I made a modification in the code, that I could share if you like, that enables the application to mute each video individually without using the hardware control of the iOS device.

Thank you,
Paulo

Re: VLCAudio class support

Posted: 02 Sep 2015 10:31
by fkuehne
We removed this class for VLCKit 3.0 because we didn't see the use, however this is not finalized yet and we are open for suggestions. We would be very happy about your patch :)

Re: VLCAudio class support

Posted: 02 Sep 2015 14:56
by pvms78
Hi,
Ok. Will provide the patch until tomorrow.
It changes the audiounit_ios module from C-file to M-file. This way, it removes some deprecated methods.
Thank you

Re: VLCAudio class support

Posted: 07 Sep 2015 12:52
by fkuehne
Ping ;)

Re: VLCAudio class support

Posted: 16 Sep 2015 13:07
by pvms78
Hi, sorry for the delay. I have been overwhelmed by work and could not write this patch. Will do as soon as I can.
Thank you

Re: VLCAudio class support

Posted: 16 Sep 2015 13:39
by fkuehne
No worries, looking forward to it!

Re: VLCAudio class support

Posted: 05 Oct 2015 01:50
by pvms78
Hi, I've sent the patch to enable audio mute for VLC library. How should I send a patch to VLCKit now that it has been moved to videolan Gitlab.

Re: VLCAudio class support

Posted: 05 Oct 2015 18:18
by zasuk
with this i'll be able to mute one video if for example i have two playing at same time?

Re: VLCAudio class support

Posted: 05 Oct 2015 21:54
by pvms78
Yes. A Patch to MobileVLCKit will also be needed.

Re: VLCAudio class support

Posted: 05 Oct 2015 22:43
by fkuehne
Hello,

I'll merge your patch in a few minutes once it completed my tests.

For the VLCKit patch, feel free to send it either to the iOS mailing-list or vlc-devel. We will enable pull requests on code.v.o later this year, but this is not done yet.

Thanks for your work!

Re: VLCAudio class support

Posted: 01 Nov 2015 16:32
by golopupinsky
What's the status of VLCAudio? I also develop iOS app that plays several videos simultaneously. And it requires not only muting one of them but also controlling their volume independently. Is this doable right now? Or will it be possible in the future?

Re: VLCAudio class support

Posted: 02 Nov 2015 11:03
by fkuehne
Volume setting is not supported in the iOS audio output module - in our own use-case we rely on system volume so this was never a priority to us. Should be easy to add though, patch welcome :)

FYI, mute was recently added by a forum contributor.

Re: VLCAudio class support

Posted: 02 Nov 2015 11:40
by golopupinsky
Mute doesn't work for me (I'm using couple weeks old vlckit build - that's probably the reason).
Haven't really touched vlc sources yet. Would appreciate any hints on starting point for this.