Page 1 of 1

Suggestion for WLAN Share frontend

Posted: 04 Mar 2015 07:55
by Crease29
Hello,

I'd like to improve the frontend for WLAN share on iOS.
Is there any way to contribute to the git repository?

In my first commit I'd like to add the progress in progress bars like this:
Image

Patchfile:

Code: Select all

Index: Resources/web/main.js IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- Resources/web/main.js (revision 274fb8b4099c27091c055559013d0d363bc8fda7) +++ Resources/web/main.js (revision 3454e999a1d8ceede419fe1e15db995d5094c614) @@ -40,7 +40,7 @@ var hasProgressbar = ('FormData' in window); var html = '<li data-file-id="' + file._ID + '">'; html += '<div class="filename">' + file.name + '</div>'; - html += '<div class="progress"><div class="bar" style="width: 0%"></div>'; + html += '<div class="progress"><div class="bar" style="width: 0%">0%</div>'; if (!hasProgressbar) { html += '<span class="dots"></span>'; } html += '</div>'; if (hasProgressbar) { html += '<div class="stop"></div>'; } @@ -72,14 +72,14 @@ function done (e, data) { $.each(data.files, function (index, file) { xhrCache.splice(file._ID, 1); - $('li[data-file-id=' + file._ID + ']').addClass('done'); + $('li[data-file-id=' + file._ID + ']').addClass('done').text('100%'); }); } function progress (e, data) { var prog = Math.ceil(data.loaded / data.total * 100) + '%'; $.each(data.files, function (index, file) { - $('li[data-file-id=' + file._ID + '] .progress .bar').css('width', prog); + $('li[data-file-id=' + file._ID + '] .progress .bar').css('width', prog).text(prog); }); } @@ -87,7 +87,7 @@ console.log('File transfer failed', data.errorThrown, data.textStatus); $.each(data.files, function (index, file) { xhrCache.splice(file._ID, 1); - $('li[data-file-id=' + file._ID + ']').addClass('fail'); + $('li[data-file-id=' + file._ID + ']').addClass('fail').text(''); }); } \ No newline at end of file Index: Resources/web/style.css IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- Resources/web/style.css (revision 274fb8b4099c27091c055559013d0d363bc8fda7) +++ Resources/web/style.css (revision 3454e999a1d8ceede419fe1e15db995d5094c614) @@ -461,7 +461,9 @@ left:0px; right:0px; bottom:0px; - border-radius: 20px; + border-radius:20px; + color:#1F1F1F; + text-align:center; } .uploads li.fail .progress .bar {
Best regards.

Re: Suggestion for WLAN Share frontend

Posted: 04 Mar 2015 10:30
by Jean-Baptiste Kempf
You can create a git patch and send it to the mailing list.

Re: Suggestion for WLAN Share frontend

Posted: 04 Mar 2015 15:37
by fkuehne
This looks great to me. Alternatively to subscribing to the iOS mailing-list, feel free to email me at feepk at videolan dot org with a patch formatted according to https://wiki.videolan.org/Sending_Patches_VLC/

In case you are interested in contributing further to the web front end, we have 2 open tickets on our tracker right now: ticket 11898 and ticket 11240.

Re: Suggestion for WLAN Share frontend

Posted: 06 Mar 2015 07:26
by Crease29
Thanks Felix, you've got mail.

Re: Suggestion for WLAN Share frontend

Posted: 06 Mar 2015 12:11
by fkuehne
Got it, I'll process it later today :)