Suggestion for WLAN Share frontend

iOS, iPad, iPhone, tvOS specific usage questions
Crease29
New Cone
New Cone
Posts: 2
Joined: 04 Mar 2015 07:50

Suggestion for WLAN Share frontend

Postby Crease29 » 04 Mar 2015 07:55

Hello,

I'd like to improve the frontend for WLAN share on iOS.
Is there any way to contribute to the git repository?

In my first commit I'd like to add the progress in progress bars like this:
Image

Patchfile:

Code: Select all

Index: Resources/web/main.js IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- Resources/web/main.js (revision 274fb8b4099c27091c055559013d0d363bc8fda7) +++ Resources/web/main.js (revision 3454e999a1d8ceede419fe1e15db995d5094c614) @@ -40,7 +40,7 @@ var hasProgressbar = ('FormData' in window); var html = '<li data-file-id="' + file._ID + '">'; html += '<div class="filename">' + file.name + '</div>'; - html += '<div class="progress"><div class="bar" style="width: 0%"></div>'; + html += '<div class="progress"><div class="bar" style="width: 0%">0%</div>'; if (!hasProgressbar) { html += '<span class="dots"></span>'; } html += '</div>'; if (hasProgressbar) { html += '<div class="stop"></div>'; } @@ -72,14 +72,14 @@ function done (e, data) { $.each(data.files, function (index, file) { xhrCache.splice(file._ID, 1); - $('li[data-file-id=' + file._ID + ']').addClass('done'); + $('li[data-file-id=' + file._ID + ']').addClass('done').text('100%'); }); } function progress (e, data) { var prog = Math.ceil(data.loaded / data.total * 100) + '%'; $.each(data.files, function (index, file) { - $('li[data-file-id=' + file._ID + '] .progress .bar').css('width', prog); + $('li[data-file-id=' + file._ID + '] .progress .bar').css('width', prog).text(prog); }); } @@ -87,7 +87,7 @@ console.log('File transfer failed', data.errorThrown, data.textStatus); $.each(data.files, function (index, file) { xhrCache.splice(file._ID, 1); - $('li[data-file-id=' + file._ID + ']').addClass('fail'); + $('li[data-file-id=' + file._ID + ']').addClass('fail').text(''); }); } \ No newline at end of file Index: Resources/web/style.css IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- Resources/web/style.css (revision 274fb8b4099c27091c055559013d0d363bc8fda7) +++ Resources/web/style.css (revision 3454e999a1d8ceede419fe1e15db995d5094c614) @@ -461,7 +461,9 @@ left:0px; right:0px; bottom:0px; - border-radius: 20px; + border-radius:20px; + color:#1F1F1F; + text-align:center; } .uploads li.fail .progress .bar {
Best regards.

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: Suggestion for WLAN Share frontend

Postby Jean-Baptiste Kempf » 04 Mar 2015 10:30

You can create a git patch and send it to the mailing list.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

fkuehne
Developer
Developer
Posts: 7295
Joined: 16 Mar 2004 19:37
VLC version: 0.4.6 - present
Operating System: Darwin
Location: Germany
Contact:

Re: Suggestion for WLAN Share frontend

Postby fkuehne » 04 Mar 2015 15:37

This looks great to me. Alternatively to subscribing to the iOS mailing-list, feel free to email me at feepk at videolan dot org with a patch formatted according to https://wiki.videolan.org/Sending_Patches_VLC/

In case you are interested in contributing further to the web front end, we have 2 open tickets on our tracker right now: ticket 11898 and ticket 11240.
VideoLAN
Felix Paul Kühne
Medic. VLC developer for appleOS since before you were born.
Blog: https://www.feepk.net

Crease29
New Cone
New Cone
Posts: 2
Joined: 04 Mar 2015 07:50

Re: Suggestion for WLAN Share frontend

Postby Crease29 » 06 Mar 2015 07:26

Thanks Felix, you've got mail.

fkuehne
Developer
Developer
Posts: 7295
Joined: 16 Mar 2004 19:37
VLC version: 0.4.6 - present
Operating System: Darwin
Location: Germany
Contact:

Re: Suggestion for WLAN Share frontend

Postby fkuehne » 06 Mar 2015 12:11

Got it, I'll process it later today :)
VideoLAN
Felix Paul Kühne
Medic. VLC developer for appleOS since before you were born.
Blog: https://www.feepk.net


Return to “VLC for iOS, iPadOS and Apple TV”

Who is online

Users browsing this forum: No registered users and 21 guests