Galaxy S3: File Crash [Semi-Complete Patch]

VLC for Android and Chrome OS specific usage questions
asad78611
New Cone
New Cone
Posts: 2
Joined: 21 Apr 2007 17:12

Galaxy S3: File Crash [Semi-Complete Patch]

Postby asad78611 » 27 Dec 2012 20:33

In the Galaxy S3 (GT-I9300), the video output buffer pitch is equal to the requested (width*4).When the width is a multiple of 2 but not 4. The buffer is not 128 bit aligned. This results in an unaligned write to the buffer causing a SIGBUS code 128. This is fixed by setting the vst4 as 64 bit aligned (2 pixels). I believe it isn't possible to have a width which isn't a multiple of 2.
In arm_neon/1420_rgb.S, the WIDTH is rounded up to a multiple of 16. This will Overflow the buffer at the end of the of the row if the OPITCH is not greater than the WIDTH rounded up.

My current fix would stop the crashes, but would leave up to 14 pixels blank at the end of the row if the OPITCH is not a multiple of 16.

PATCH: http://pastebin.com/gRKewmZF

Return to “VLC for Android and Chrome OS”

Who is online

Users browsing this forum: No registered users and 37 guests