Performance tests ? (JBK on ZDnet)

[dmfr77]

Hi,
Just a dumb question for JBK, on a ZDnet interview you spoke about a noticeable VLC performance gap between SGS3 and OneX.
Just for the record, which one is better ? Have you come across potential explanation ( ROMs, drivers, hardware ) ?
Sorry for the OT.

Btw VLC is now my default player, on both Iconia A500 (tegra2) and HTC Desire (reg. NEON), and works just fine.
One small issue on Iconia CM10: somehow

Code: Select all

mSurface.setSystemUiVisibility(View.SYSTEM_UI_FLAG_HIDE_NAVIGATION)

doesn't work and leaves softbuttons active.
If anyone interested, find below a diff against current GIT for my own personal build.

Thanks again for the excellent work !

Code: Select all

diff --git a/java-libs/SlidingMenu/project.properties b/java-libs/SlidingMenu/project.properties index 5ca7d62..f28bc83 100644 --- a/java-libs/SlidingMenu/project.properties +++ b/java-libs/SlidingMenu/project.properties @@ -9,4 +9,4 @@ android.library=true # Project target. -target=android-14 +target=android-15 diff --git a/vlc-android/src/org/videolan/vlc/gui/MainActivity.java b/vlc-android/src/org/videolan/vlc/gui/MainActivity.java index 56249ac..92d32e9 100644 --- a/vlc-android/src/org/videolan/vlc/gui/MainActivity.java +++ b/vlc-android/src/org/videolan/vlc/gui/MainActivity.java @@ -215,8 +215,9 @@ public class MainActivity extends SherlockFragmentActivity { if (pinfo != null) { mVersionNumber = pinfo.versionCode; - if (mSettings.getInt(PREF_SHOW_INFO, -1) != mVersionNumber) - showInfoDialog(); + if (mSettings.getInt(PREF_SHOW_INFO, -1) != mVersionNumber) { + //showInfoDialog(); + } } /* Prepare the progressBar */ diff --git a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java index 3659ba1..2ee2d9e 100644 --- a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java +++ b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java @@ -1089,9 +1089,11 @@ public class VideoPlayerActivity extends Activity { private void dimStatusBar(boolean dim) { if (Util.isHoneycombOrLater()) { if (dim) { + /* mSurface.setSystemUiVisibility(Util.hasNavBar() ? View.SYSTEM_UI_FLAG_HIDE_NAVIGATION - : View.SYSTEM_UI_FLAG_LOW_PROFILE); + : View.SYSTEM_UI_FLAG_LOW_PROFILE);*/ + mSurface.setSystemUiVisibility(View.SYSTEM_UI_FLAG_LOW_PROFILE); } else { mSurface.setSystemUiVisibility(View.SYSTEM_UI_FLAG_VISIBLE); }

[Jean-Baptiste Kempf]

Just a dumb question for JBK, on a ZDnet interview you spoke about a noticeable VLC performance gap between SGS3 and OneX.
Just for the record, which one is better ? Have you come across potential explanation ( ROMs, drivers, hardware ) ?

SG3

Btw VLC is now my default player, on both Iconia A500 (tegra2) and HTC Desire (reg. NEON), and works just fine.
One small issue on Iconia CM10: somehow

Code: Select all

mSurface.setSystemUiVisibility(View.SYSTEM_UI_FLAG_HIDE_NAVIGATION)

doesn't work and leaves softbuttons active.
If anyone interested, find below a diff against current GIT for my own personal build.

Can you send that to me by mail?

[dmfr77]

Can you send that to me by mail?

You mean a PM ?
I didn't do anything but replace SYSTEM_UI_FLAG_HIDE_NAVIGATION with SYSTEM_UI_FLAG_LOW_PROFILE which is known to work better (even it just dims soft buttons).
There are a few developer's reports where SYSTEM_UI_FLAG_HIDE_NAVIGATION seems to have no effect (depends on ROM / device). Perhaps used in conjunction with SYSTEM_UI_FLAG_FULLSCREEN it'll work better. I'll give it a try.

[Jean-Baptiste Kempf]

This is a mess, to be honest