Page 1 of 1

Equalizer in 2.1.0

Posted: 17 Oct 2012 16:51
by mangokm40
I downloaded last night's 2.1.0 build to try the equalizer code. I didn't see it in there. Has it been removed from future plans?

Thanks

Re: Equalizer in 2.1.0

Posted: 17 Oct 2012 17:07
by sherington
It was committed prematurely.

The patch was not acceptable.

I don't have the time to spend or inclination to get it over the finishing line.

It was subsequently rightly reverted.

Re: Equalizer in 2.1.0

Posted: 17 Oct 2012 17:16
by mangokm40
That's too bad.
I'm a moron, but if the work is simple (just time-consuming), I'd be happy to help.

Re: Equalizer in 2.1.0

Posted: 15 Nov 2012 11:45
by MichaelMc
It was committed prematurely.

The patch was not acceptable.

I don't have the time to spend or inclination to get it over the finishing line.

It was subsequently rightly reverted.
Would it be possible if you could post the required patches? I ask as I'd already implemented a UI for this in preparation for this with the VLC 2.1.0 release and i'd like to see if there is anything I can do.

Re: Equalizer in 2.1.0

Posted: 15 Nov 2012 14:20
by sherington
They're all there on the vlc-devel mailing list, along with a lot of review comments. There's a long thread with a few different approaches, but alas not a correct approach.