Page 1 of 1

MIDI demuxer fails to process some odd MIDI files

Posted: 30 Jan 2019 09:22
by Wohlstand
Hello!
Recently I have got some weird MIDI files are playing fine in some players (as example, my), but won't be played in VLC and won't be opened in MIDI Editors:
https://github.com/Wohlstand/libADLMIDI ... -458643417

The reason of this has been explained here:
The reason for failure: the meta-event Key-Signature needs 2 bytes of payload, these files have 0.

For VLC, it should be requested to implement permissive parsing to bypass such an error. There are just too numerous MIDI files floating around which don't conform.
Sekaiju needs to implement rigourous bounds checking.

Re: MIDI demuxer fails to process some odd MIDI files

Posted: 30 Jan 2019 19:59
by RĂ©mi Denis-Courmont
Sigh. File a bug on Trac with a sample file.

Re: MIDI demuxer fails to process some odd MIDI files

Posted: 31 Jan 2019 09:06
by Wohlstand
Reported!
https://trac.videolan.org/vlc/ticket/21857
I have attached the ZIP archive that contains those odd MIDI files are can't be played, and I have put log piece that was reported by user of my libADLMIDI plugin.

Re: MIDI demuxer fails to process some odd MIDI files

Posted: 10 Mar 2019 21:47
by Jean-Baptiste Kempf
Fixed for 3.0.7