Page 1 of 1

SAT>IP access module improvement

Posted: 07 Jun 2018 13:45
by athosman
Hi,

The current implementation of the SAT>IP access module uses internal (aka custom) code for reading RTP packets. However, the RTP access module has a more advanced implementation. For example, the RTP module can read reordered UDP packets, but not for the SAT>IP module. See the differences here:
- SAT>IP: https://github.com/videolan/vlc/blob/db ... tip.c#L339
- RTP: https://github.com/videolan/vlc/blob/db ... ion.c#L327

I suggest to reuse the RTP code in the SAT>IP module, and remove redundant code.

Regards.

Re: SAT>IP access module improvement

Posted: 18 Jun 2018 14:04
by athosman
Hi,

No comment?

I have another suggestion: For the CUSTOM SAT>IP CHANNEL LIST, I recommand to support 4 different URLs, each one for any of the four different SAT sources (src=1, src=2, src=3 & src=4). So when you have more than one satellite position, then you can use the correct list for each position.

You agree?

Re: SAT>IP access module improvement

Posted: 18 Jun 2018 18:01
by Jean-Baptiste Kempf
Because the SAT>IP protocol is a bit weird. But yes, patches are very welcome on this.