Page 1 of 1

VLC live555.cpp crash

Posted: 05 Jul 2013 14:21
by balasubramanya
Hi,

We are not taking care of malloc failures in block_New calls. Like following portion of code in streamread() in

Code: Select all

if( tk->fmt.i_codec == VLC_CODEC_H264 ) { if( (tk->p_buffer[0] & 0x1f) >= 24 ) msg_Warn( p_demux, "unsupported NAL type for H264" ); /* Normal NAL type */ p_block = block_New( p_demux, i_size + 4 ); p_block->p_buffer[0] = 0x00; p_block->p_buffer[1] = 0x00; p_block->p_buffer[2] = 0x00; p_block->p_buffer[3] = 0x01; memcpy( &p_block->p_buffer[4], tk->p_buffer, i_size ); }
I am getting a crash in p_block->p_buffer[0] = 0x00; line. I am using VLC 1.1.11 version.

Regards,
Bala

Re: VLC live555.cpp crash

Posted: 06 Jul 2013 10:06
by RĂ©mi Denis-Courmont
I don't know how you trigger the crash, but you should file a bug.

Re: VLC live555.cpp crash

Posted: 06 Jul 2013 17:12
by balasubramanya
The crash is happening while rtsp vlc playback from IE browser plugin. It is not consistent crash. I will check the scenario and file a bug.