SAT>IP access module improvement

For questions and discussion that is NOT (I repeat NOT) specific to a certain Operating System.
athosman
New Cone
New Cone
Posts: 6
Joined: 30 May 2018 15:16

SAT>IP access module improvement

Postby athosman » 07 Jun 2018 13:45

Hi,

The current implementation of the SAT>IP access module uses internal (aka custom) code for reading RTP packets. However, the RTP access module has a more advanced implementation. For example, the RTP module can read reordered UDP packets, but not for the SAT>IP module. See the differences here:
- SAT>IP: https://github.com/videolan/vlc/blob/db ... tip.c#L339
- RTP: https://github.com/videolan/vlc/blob/db ... ion.c#L327

I suggest to reuse the RTP code in the SAT>IP module, and remove redundant code.

Regards.

athosman
New Cone
New Cone
Posts: 6
Joined: 30 May 2018 15:16

Re: SAT>IP access module improvement

Postby athosman » 18 Jun 2018 14:04

Hi,

No comment?

I have another suggestion: For the CUSTOM SAT>IP CHANNEL LIST, I recommand to support 4 different URLs, each one for any of the four different SAT sources (src=1, src=2, src=3 & src=4). So when you have more than one satellite position, then you can use the correct list for each position.

You agree?

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: SAT>IP access module improvement

Postby Jean-Baptiste Kempf » 18 Jun 2018 18:01

Because the SAT>IP protocol is a bit weird. But yes, patches are very welcome on this.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.


Return to “General VLC media player Troubleshooting”

Who is online

Users browsing this forum: No registered users and 64 guests