Page 1 of 1

I made a module for VLC - interested?

Posted: 27 Sep 2017 16:19
by ASantosVal
Hi everyone,

I'm a computer engineer and for my degree's final project I made a module for VLC. It's an Extended Metadata Manager for VLC, which is designed to process multiple file's metadata, to be able to edit them manually on a table, and to fingerprint & search them on acoustId. It's implemented with C++ & Qt (so it works on Windows and Linux). It adds no new dependencies to VLC, it's all done with C++ code and VLC's API. It's also very light, about 15kB code and 300kB on pixmaps (which could be reduced to 5kB by removing/resizing some of them).

Would VideoLAN be interested in adding the module to the official version? If so, I would make any necessary changes.

The module works quite fine, but still has some bugs/improvements I'm working on. My degree's project is finished, so I just want to contribute to the community.

It's a functionality which has been asks by some users: Here is my repository:
https://github.com/ASantosVal/EMM_for_VLC

And here some screenshots:
  1. The module itself:
    Image
  2. The module's menu entry:
    Image
Hope you like it.
Asier Santos

Re: I made a module for VLC - interested?

Posted: 29 Sep 2017 20:05
by Jean-Baptiste Kempf
YES! Like YES, YES!

Re: I made a module for VLC - interested?

Posted: 01 Oct 2017 12:20
by ASantosVal
Great news!

I would like to fix a couple of things during the following weeks, but I think it will be ready really soon. Once that is done, how should I proceed? I read that you usually ask developers to create and send patches, is that still right? Any modifications I should do?

I also read that this kind of in-tree developments are a good chance to get the code reviewed by VideoLAN. How do you usually do these reviews?

I'm really thrilled about this.
Asier Santos

Re: I made a module for VLC - interested?

Posted: 01 Oct 2017 13:10
by InTheWings
We really need to find a way to disable edit/save in UI when the format does not support it

Re: I made a module for VLC - interested?

Posted: 01 Oct 2017 21:49
by Jean-Baptiste Kempf
Great news!

I would like to fix a couple of things during the following weeks, but I think it will be ready really soon. Once that is done, how should I proceed? I read that you usually ask developers to create and send patches, is that still right? Any modifications I should do?

I also read that this kind of in-tree developments are a good chance to get the code reviewed by VideoLAN. How do you usually do these reviews?

I'm really thrilled about this.
Asier Santos
Yes, send them over, when ready, and we'll review.

Re: I made a module for VLC - interested?

Posted: 01 Oct 2017 21:49
by Jean-Baptiste Kempf
We really need to find a way to disable edit/save in UI when the format does not support it
Yep, that too.

Re: I made a module for VLC - interested?

Posted: 01 Oct 2017 21:51
by ASantosVal
We really need to find a way to disable edit/save in UI when the format does not support it
Yep, that too.
Actually, it's supposed to filter the files while loading and only add to the table the supported ones, but I have only tested a few combinations. Have you tried it and found a bug, or was it just a suggestion?

Re: I made a module for VLC - interested?

Posted: 04 Oct 2017 15:50
by Jean-Baptiste Kempf
We really need to find a way to disable edit/save in UI when the format does not support it
Yep, that too.
Actually, it's supposed to filter the files while loading and only add to the table the supported ones, but I have only tested a few combinations. Have you tried it and found a bug, or was it just a suggestion?
Just a suggestion from experience.