Automatically Replace all instances of the Color Prefix 0x with &H when loading ass/ssa subtitles

[Kamijou Touma]

Here is an example of a header that will result in Black Subtitles in VLC

Code: Select all

;------------------------------------------------ [V4 Styles] Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, TertiaryColour, BackColour, Bold, Italic, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, AlphaLevel, Encoding ; Normal styles Style: Default, Augie, 32, 0xecffff,0,0,0x003164,0,0,1,2,2,2,20,20,10,0,0 Style: Note, Augie, 25, 0xecffff,0,0,0x777c7f,0,0,1,2,2,6,20,20,10,0,0 ; OP styles Style: English, Inkblob, 25, 0x25d7fd,0,0,0x002899,0,0,1,2,2,2,20,20,15,0,0 Style: Romaji, Koshgarian-Ligh, 19, 0xfff4e6,0,0,0x74491e,0,0,1,1,2,6,20,20,15,0,0 Style: Kanji, Mona, 24, 0xffe8cc,0,0,0x8e5a26,0,0,1,2,2,6,20,20,15,0,0 Style: Kanji-LT, Mona, 24, 0xfff0d0,0,0,0x8e5a26,0,0,1,2,2,5,20,20,50,0,0 Style: Kanji-RT, Mona, 24, 0xfff0d0,0,0,0x8e5a26,0,0,1,2,2,7,20,20,50,0,0 ; ED styles Style: ED-English,Amazone BT, 35, 0xf1e8f7,0,0,0x30204b,-1,0,1,1,2,2,20,20,8,0,0 Style: ED-Romaji, Footlight MT Light, 21, 0xfff4e6,0,0,0x74491e, 0,0,1,1,2,6,20,20,15,0,0 Style: ED-Kanji, MS PMincho, 24, 0xffe8cc,0,0,0x8e5a26, 0,0,1,2,2,6,20,20,15,0,0 ;------------------------------------------------

http://i.imgur.com/DMA77xE.png < image of the issue


Here is an example of a header that will result in properly colored subtitles in VLC

Code: Select all

;------------------------------------------------ [V4 Styles] Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, TertiaryColour, BackColour, Bold, Italic, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, AlphaLevel, Encoding ; Normal styles Style: Default, Augie, 32, &Hecffff,0,0,&H003164,0,0,1,2,2,2,20,20,10,0,0 Style: Note, Augie, 25, &Hecffff,0,0,&H777c7f,0,0,1,2,2,6,20,20,10,0,0 ; OP styles Style: English, Inkblob, 25, &H25d7fd,0,0,&H002899,0,0,1,2,2,2,20,20,15,0,0 Style: Romaji, Koshgarian-Ligh, 19, &Hfff4e6,0,0,&H74491e,0,0,1,1,2,6,20,20,15,0,0 Style: Kanji, Mona, 24, &Hffe8cc,0,0,&H8e5a26,0,0,1,2,2,6,20,20,15,0,0 Style: Kanji-LT, Mona, 24, &Hfff0d0,0,0,&H8e5a26,0,0,1,2,2,5,20,20,50,0,0 Style: Kanji-RT, Mona, 24, &Hfff0d0,0,0,&H8e5a26,0,0,1,2,2,7,20,20,50,0,0 ; ED styles Style: ED-English,Amazone BT, 35, &Hf1e8f7,0,0,&H30204b,-1,0,1,1,2,2,20,20,8,0,0 Style: ED-Romaji, Footlight MT Light, 21, &Hfff4e6,0,0,&H74491e, 0,0,1,1,2,6,20,20,15,0,0 Style: ED-Kanji, MS PMincho, 24, &Hffe8cc,0,0,&H8e5a26, 0,0,1,2,2,6,20,20,15,0,0 ;------------------------------------------------

http://i.imgur.com/7oPGRKl.png < image of the fix

http://i.imgur.com/y2ImD3v.png < comparison with mpc-hc


HandBrake currently Shares this issue with VLC but i have already talked to some of their devs about it and i will be committing a patch that does what the title of this thread says

[Rodeo]

I said that I'd look into it, but made no promises of a patch or even an ETA

[Jean-Baptiste Kempf]

It's a libass bug, I think

[Rodeo]

It's a libass bug, I think

I thought so too, but I can't seem to find a definitive reference as to whether colors coded as 0x<foo> are valid. Whether it's a workaround or a fix, making it available in libass would be easiest anyway.

[Rodeo]

Aegisub also fails to parse the colors in the header above, FWIW.

[Kamijou Touma]

Made a feature request on Aegisub UserVoice http://aegisub.uservoice.com/forums/126 ... ssa-header
and on HandBrake https://forum.handbrake.fr/viewtopic.php?f=26&t=32481

Both will pretty much be following along with this thread for the time being instead of info being all over the place

Cant make a patch till we know for sure what the culprit is after all

[Kamijou Touma]

Added a git issue on libass so they can take a look and give us feedback

https://github.com/libass/libass/issues/178

I honestly still find it weird that mpc-hc can render color with that prefix 0x but meh heck if libass ends up just making 0x parse the same way as &H instead of just replacing 0x with &H when it's parsed than that works too.

But thats only if that's the issue.

[Kamijou Touma]

Confirmed a known libass "low-priority" issue by a collaborator

He said he will spend some time working on a full fix.

[Jean-Baptiste Kempf]

Added a git issue on libass so they can take a look and give us feedback

https://github.com/libass/libass/issues/178

I honestly still find it weird that mpc-hc can render color with that prefix 0x but meh heck if libass ends up just making 0x parse the same way as &H instead of just replacing 0x with &H when it's parsed than that works too.

But thats only if that's the issue.

MPC-HC uses VSFilter, which is a mess, implementing many things outside of spec.

Since there is no real spec, what is implemented in VSFilter is the de-facto spec... Nice... Not.

[Kamijou Touma]

https://github.com/libass/libass/commit ... d8022190db