VLC entry is not translated and no icon in Windows autoplay

[secarica]

The Windows has an autoplay menu that pops-up at CD or DVD insertion (if not disabled).
At present, the language of that menu is not translated. More than that, the way it is set today means it is only a per-machine language string, not per-user as it should be.
This string is set at install time, the key name is "Action" and is located here
HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\AutoplayHandlers\Handlers\VLCPlayCDAudioOnArrival
and here
HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\AutoplayHandlers\Handlers\VLCPlayDVDMovieOnArrival

Other than that, the installer script appears to have a bug (?). The key name "DefaultIcon" located here
HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\AutoplayHandlers\Handlers\VLCPlayCDAudioOnArrival
is set to be
"C:\Program Files\VideoLAN\VLC\vlc.exe --started-from-file",0
whereas it should be
"C:\Program Files\VideoLAN\VLC\vlc.exe",0
Because of this, no VLC icon appears in the autoplay dialog.
In this case the "DefaultIcon" for DVD is ok, the problem is only with the CD.

This is what I mean:





Cristi

[Jean-Baptiste Kempf]

Cristi, seriously, why don't you modify the .nsi script and give us it ?
You know that better than we do

Best

[secarica]

Well, I can do that, but where is the NSIS script file located ?
It is the same for version 0.8.6x and for 0.9.0 ?

Other than this, we must agree with the concept on the first issue mentioned above. For exemple, I tested with French locale and a French VLC installation: the same problem, in the autoplay menu the language string for VLC remains in English.
I suppose the string's language can be set according to the language choosed at install time, but there are some issues to be highlighted:

• the language of that string will depend only on the language selection at install time; the VLC program preference or the main system language selection cannot change that language string at a later time; do you agree with this ?
• giving the nature of the HKLM registry entries, the language of that string will be the same for all users (per-system); while this is of no importance on systems with a single overall language, or a language set via LIP (Language Interface Pack), this can be incorrect on systems with MUI (Multilanguage User Interface) installed, where each user can set its own system language preference if so desired; it is true that the MUI is only available for a limited set of languages and may be even difficult to obtain (MUI for Windows XP is only available on special licensing and MUI for Windows Vista is only available on Business and Ultimate versions); do you agree with this ?
• I cannot translate this string for other languages inside NSIS script; even if I know what to write for a few of the languages, I don't want to do that, this should be the responsability of the language maintainers for each language

Sidenote: in the Windows's autoplay dialog, the language strings for Windows Media Player are translated according to the user language preference at system level, but this is due to the specific resource translation mechanism used by Microsoft, which is MUI related (.dll resource files with .mui extension).

Cristi

[Jean-Baptiste Kempf]

http://trac.videolan.org/vlc/browser/tr ... n32.nsi.in

I don't know how to make it multi-lingual from the installer.

[xtophe]

This is a long standing problem last discussed last summer in http://article.gmane.org/gmane.comp.vid ... +installer

I'm willing to review any patch and do the integration with automake and the buildsystem. But not to do the nsis part.

[secarica]

I currently investigating myself the issue. I know what to do (static solution, i.e. per-system translation, set by installer language selector), but I have to check it first.
One thing is for sure: in the NSIS installer script, line 412 must be corrected from

Code: Select all

WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Explorer\AutoplayHandlers\Handlers\VLCPlayCDAudioOnArrival" "DefaultIcon" '"$INSTDIR\vlc.exe --started-from-file",0'

to

Code: Select all

WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Explorer\AutoplayHandlers\Handlers\VLCPlayCDAudioOnArrival" "DefaultIcon" '"$INSTDIR\vlc.exe",0'

This is for the missing icon.

Other thing is the possibility to have the (GNU) license displayed in the installer selected language (or in English if the translation is not available for that language), but the translation of the license should be discussed separately, there are some possible legal issues.

Cristi

[Jean-Baptiste Kempf]

This is fixed.

I am not really sure it would be good to do the license in non-english...

[secarica]

I currently investigating myself the issue. I know what to do (static solution, i.e. per-system translation, set by installer language selector), but I have to check it first.

I am not happy with my tests and for the moment I have no proper solution.
Reason: any custom localized text that is not included in the default NSIS’s language files must be written explicitly inside the script. Because today the script is 8 bit codepage rather than Unicode, multilanguage strings may not display correctly, let alone that it is difficult to write them down to the script.
So, at the moment there is no easy solution to translate the language of that menu ... (but if I will find something useful I will return here)

Cristi

[Jean-Baptiste Kempf]

I am sad to hear that.