Page 1 of 1

Simple "File Open" with a Skin on my VLC?

Posted: 10 Dec 2009 00:17
by Drachenstein
Hi there

When I use skins with my VLC the menu item of a simple "file open" seems to be missing. There's only "Open Media" which I don't like because it needs more clicks to open a file. Without a skin this menu option is available.

Is this a normal behaviour with skins or am I doing somethin wrong? Can I add this command in an existing skin with a skin editor?

I use the skin "WMP11" from the videolan.org page (http://www1.videolan.org/vlc/download-s ... =WMP11.vlt)

Thanks for any hints!

Wolfgang

Re: Simple "File Open" with a Skin on my VLC?

Posted: 10 Dec 2009 13:43
by 3breadt
There is an action available in skins2 to do so, you can change skins to use it with the skin editor.

Open the skin, locate the open button and change its action to dialogs.fileSimple().

Re: Simple "File Open" with a Skin on my VLC?

Posted: 10 Dec 2009 15:24
by Drachenstein
There is an action available in skins2 to do so, you can change skins to use it with the skin editor.

Open the skin, locate the open button and change its action to dialogs.fileSimple().
Cool, that's really easy - thanks for the hint!

I used VLC Skin Editor 0.8.6dev to do so and I tested it with a new button that only would quickly open a file. But I'm confused, it looks like the behaviour of the two commands

- dialogs.fileSimple()
- dialogs.file()

both do open this unwanted "Open Media" Window with all the tabs for "File", "Volume", "Network" and so on.

Any idea what could be wrong?

Thanks - Wolfgang

Re: Simple "File Open" with a Skin on my VLC?

Posted: 10 Dec 2009 17:58
by 3breadt
Really?
That's strange. Maybe one of the devs has an idea, normally dialogs.fileSimple() should only open the simple "open file" dialog according to the documentation. Maybe its not properly implemented in the skins system.
Or I'm misunderstanding the meaning of "simple open file dialog" :D

Re: Simple "File Open" with a Skin on my VLC?

Posted: 10 Dec 2009 18:30
by erwan10
Yes, it's weird, and the culprit seems to be the qt4 dialog provider :

Code: Select all

in modules/gui/qt4/dialogs_provider.cpp : switch( de->i_dialog ) { case INTF_DIALOG_FILE_SIMPLE: case INTF_DIALOG_FILE: openDialog(); break; case INTF_DIALOG_FILE_GENERIC:
fileSimple() and file() actually end up executing the same code. Any reason for that ?

Erwan10

Re: Simple "File Open" with a Skin on my VLC?

Posted: 10 Dec 2009 22:31
by 3breadt
Bug?

Re: Simple "File Open" with a Skin on my VLC?

Posted: 10 Dec 2009 23:39
by Drachenstein
What a pitty!

I installed WIndows 7 and I'm so sad because Windows Media Player 11 (from Vista) was so beautiful and now I lost it: with Windows 7 the Windows Media Player 12 looks ugly.

I thought I'm clever and I take VLC with the WMP11 skin - and now I can't even open a file (in a simple way) :shock:

Re: Simple "File Open" with a Skin on my VLC?

Posted: 11 Dec 2009 08:46
by Jean-Baptiste Kempf
Yes, it's weird, and the culprit seems to be the qt4 dialog provider :

Code: Select all

in modules/gui/qt4/dialogs_provider.cpp : switch( de->i_dialog ) { case INTF_DIALOG_FILE_SIMPLE: case INTF_DIALOG_FILE: openDialog(); break; case INTF_DIALOG_FILE_GENERIC:
fileSimple() and file() actually end up executing the same code. Any reason for that ?

Erwan10
Stupidity from my part?

It needs fixing for a future version :D

Re: Simple "File Open" with a Skin on my VLC?

Posted: 11 Dec 2009 08:47
by Jean-Baptiste Kempf
What a pitty!
It will be fixed in a future version of VLC.

Re: Simple "File Open" with a Skin on my VLC?

Posted: 11 Dec 2009 16:03
by Drachenstein
Yuppieee!