Page 4 of 5

Posted: 25 Apr 2006 08:43
by ipkiss
I added this black bar around the bottom right corner of the video window to indicate resizability.
Since the black bar is a decoration elsewhere, this is not enough to indicate resizability...


Also, what about a miniature mode?

Posted: 25 Apr 2006 10:01
by AsMaX
But the font is so "delicious" :) I can reed it very good! Need glasses :twisted: ?
Maybe I need glasses too ;) but indeed i don't find it very readable in the playlist (do you have a LCD screen ?)

Posted: 25 Apr 2006 13:36
by Khamelion
Maybe I need glasses too ;) but indeed i don't find it very readable in the playlist (do you have a LCD screen ?)
That is the problem with the delicious skin.
I really love it. But in small size it's very hard to read.
It's very difficult to find a font, which also look clear in a small size.
Black Box? No.
Well, my problem is. When I'm playing a film, and I'm resizing it , sometimes a black box appear. When I'm resizing it a little, it dispear.
It's not that bad, but it confuse me a little.
Playlist can be closed.
I know, that the playlist can be closed, but only with the "close-button", but isn't it also possible to make the button open and close?.
Some skins support it.

and with the overcrowded buttons. I said that at the beginng too and I hope that you'll also appreciate that some doesn't want that much buttons.
If you need them, you can still add them in your own skin. But if a developer want to have it, you should accept their changes.
Don't forget, it's the default button everbody wants to have and everyone uses. :)
We also change the color and SEE so many people like it :)
Give yourself an impulse to realize the skin they want.
I think they deserve it, because of their great work :D

Posted: 25 Apr 2006 13:39
by 3breadt
@zorglub:
I see the discussion ending again in "I like your skin, but..." and so on and so on. I don't want to create a perfect skin that pleases everybody thats hardly possible.
If you dont like them feel free to edit the skin for your own needs.

@ipkiss: What would be an agreeable indicator? Those ugly nops, like in every other window?
Minimal mode might be added at last, I think of accesing it by doubleclicking on the window background. Ok?

@AsMaX:
I have not any problem reading it, using a tft monitor. Dunno how it looks on lcd or other monitors but in the line of discussion in this thread I found this font best fitting(tried already two others)

Update

Posted: 25 Apr 2006 14:08
by 3breadt
Updated Skin http://altglass.al.funpic.de/d-gfx/stuff/Default.vlt

BTW: Found Bug in latest nightly build, Windows made visible cannot be hidden anymore. Should be fixed.

Posted: 25 Apr 2006 16:16
by 3breadt
Updated again.

Now I think only minimal mode and anchors have to be done.
I hope moving anchors will be implemented tomorrow ;)

Screenshot:
Image

//EDIT: Should the buttons in the playlist window be moved onto the height of the buttons inside the video window so that all buttons are on one height or can it be left like it is?

Posted: 25 Apr 2006 18:39
by dionoea
It's getting nicer by the minute !

About the playlist buttons, current position looks fine to me.

I personnaly think that minimal mode is a "must have". You'll need a button to switch back and forth from minimal mode. Double clicking on the window background isn't intuitive enough.

btw, why did you put "Only to be used with VLC" ? :D

Posted: 25 Apr 2006 18:55
by Khamelion
I want to dock the EQ and Playlist on the video.
Why is it not possible?

By the way
It's getting better and better :)
Had you ever imagine that this skin
Image


will be change to this "look above" skin ^^

Re: Update

Posted: 25 Apr 2006 19:14
by AsMaX
BTW: Found Bug in latest nightly build, Windows made visible cannot be hidden anymore. Should be fixed.
oops stupid bug, I've just fix it...

But your skin have bugs too ;)

- you must use / and not \ as file separator, otherwise it doesn't work on linux.
(<... file "main/main_up.png" .../> for instance)
- there are two "equalizer.band(3)"

Posted: 25 Apr 2006 22:19
by Khamelion
By the way, is it possible to link the "open button" to the simple open button. Normally I don't use all these features.

Posted: 26 Apr 2006 07:22
by 3breadt
you must use / and not \ as file separator, otherwise it doesn't work on linux.
****, first I used / and then I thought this could make problems with linux, and now its the other way round lol.

Fixed both errors and updated file


@dionoea: I didnt know what to write there, so I wrote this :D

@Khamelion: I'm waiting for anchors that move their position when the window is resized otherwise you wouldn't be able to dock the windows to the edges of windows but rather somewhere inside.

Simple Open, hmmm, I think a lot of people also use the other functions so I don't know if that is a good idea.

Posted: 26 Apr 2006 11:42
by Khamelion
Simple Open, hmmm, I think a lot of people also use the other functions so I don't know if that is a good idea.
Well If they want to use other function they can also press the play button or not?

- How about putting the Fullscreen Button instead of the maximize button?
- When I'm pressing "Stop" sometimes the time display shows a very long number

Posted: 26 Apr 2006 13:52
by 3breadt
What the hell is happening, I dont understand VLC anymore.
http://altglass.al.funpic.de/d-gfx/stuff/Default.vlt

Somehow it completely ignores the positioning and the visibility of windows.
Help!

I only figured out that it seems to be an issue with the equalizer and credits window which effects the other, but i dont know what it could be. Please Help!

Posted: 26 Apr 2006 19:16
by AsMaX
Somehow it completely ignores the positioning and the visibility of windows.
It works for me... can you give more details ?

Posted: 27 Apr 2006 07:22
by 3breadt
When I loaded the skin, eq window was visible an at the position was at the position of the main window, main window was at position of playlist window,
credits window was visible at the pos of the eq.

Seems to have been an issue with my cache, or something.

//EDIT: After loading another skin before loading mine it worked.

Posted: 27 Apr 2006 09:59
by ipkiss
When I loaded the skin, eq window was visible an at the position was at the position of the main window, main window was at position of playlist window,
credits window was visible at the pos of the eq.

Seems to have been an issue with my cache, or something.
This is an issue with the skins2-config configuration option. This option remembers the last position and visibility status of the windows of the last skin (which is saved by the skins2-last configuration option).
So if you modify your skin and reload it, VLC sees that it is the same skin, and tries to use the same configuration, causing strange behaviour when a window was added/removed.

To fix this problem, we would need to store the last modification date of the skin too. But anyway the whole skins2-config option should be enhanced to be more robust and to support saving the layouts too. This will be done, one day... :-)

Posted: 27 Apr 2006 15:13
by 3breadt
Should definitely be improved ;)

I think I finished everything that is required, the only thing to add were
anchors, but as long as movable anchors are not implemented there are no Anchors in the Skin.

http://altglass.al.funpic.de/d-gfx/stuff/Default.vlt

Image

Posted: 27 Apr 2006 17:29
by janux
very nice :D excellent work!

I know you can't please everyone and it's not necessary because if someone
does not like the default skin there ist the ability to choose other skins.

But i share some opinions here so i cant' resist :lol:
- There are too many buttons. I think at least streaming wizard and messages log should go (we could add streaming wizard to the popup menu).
I have to agree. Also "change skin" an "preferences" is to much.
The other buttons are intuitional, but to know what these buttuns do I alwas have to look at the tooltip. The common user does not need them and may bee irritated. I just ignore them :wink:
font should be changed... (pretty hard to read timing)
The font ist delicious don't change it, but is it possible to use some other font just for the timing in the video window :?:
Is it normal when I'm resizing the window a "black box" appears?
Yes that's normal I have that too :lol:

Some thoughts abaut the Playlist:
  • .) Is it possible to see the track time?
    .) How can I serach for a song in the playlist?
    .) What about the ability to change the font size? could be a feature reqest...

Posted: 27 Apr 2006 18:17
by 3breadt
Buttons wont be changed anymore as I said some times already.
Font change just for timing is possible but which one should I use?
A different font would not fit so good in the overall appearance.

What exactly do you mean with "black box", I have no black box when resizing the skin. Do you use the latest nightly build?
.) Is it possible to see the track time?
No
.) How can I serach for a song in the playlist?
Sort it alphabetically and scroll ^^ There's no other way I think.
What about the ability to change the font size?
Would be possible for the playlist but I dont find this really useful.

Posted: 27 Apr 2006 22:16
by Khamelion
Font change just for timing is possible but which one should I use?
A different font would not fit so good in the overall appearance
Perhaps you can use the "Freesans" font. The numbers from FreeSans are good enough.
What exactly do you mean with "black box", I have no black box when resizing the skin. Do you use the latest nightly build?
I think that could be a bug from VLC. I tried some other Skins , which have the video-window also integrate in the skin and it has the same problems.
What happens is when you try to resize the window, everything in the video is black . Sometimes can only 25% from the video. You must resize the window again for solving that problem.
Skins with seperate Videowindow hasn't got that problem but I like it more this way.
It isn't also a very huge problem, but it's weird.

- By the way. I don't know the bug in detail, but after playing 3 or 4 Videos a small message box appears. It mention some kind of bug, but I forgot what it was. I can only play the video by restarting the player. Do somebody also know the bug?

Posted: 27 Apr 2006 23:25
by janux
Sort it alphabetically and scroll ^^ There's no other way I think.
The classic wxwidget playlist supports track time and searching the list.
Also the kontext menue (right klick on playlist entrys) is missig in your skin.

I think a new default skin should have all the features of the old one.
What exactly do you mean with "black box", I have no black box when resizing the skin. Do you use the latest nightly build?
Yes I use the latest nightly build.
And like Khamelion I think it is a bug in VLC.
(Using Windows XP/ATI Fire GL T2)
not testet under linux as I am using xine there :roll:

Posted: 28 Apr 2006 12:14
by ipkiss
The classic wxwidget playlist supports track time and searching the list.
Also the kontext menue (right klick on playlist entrys) is missig in your skin.

I think a new default skin should have all the features of the old one.
The wxWidgets interface is not a skin, it's really a different interface. So there is no regression compared to the old default skin.
The skins interface doesn't have the features you want yet, even though we should definitely add them.
not testet under linux as I am using xine there
It would be nice if you could test in on Linux too, to know if it is a Windows-specific problem.
Buttons wont be changed anymore as I said some times already.
I think there is a kind of consensus on the fact that there are too many buttons... So it is possible to please everyone! :-)
You could remove the logs button, the change skin button and the steaming wizard button...

Posted: 28 Apr 2006 12:54
by 3breadt
okay. Updated again.
Changes:
-Time uses the defaultfont provided with VLC, which currently is FreeSans.
-Removed Streaming Wizard, Message Log and Change Skin buttons
-Updated Licensing in the About Dialog so that it fits the GPL (As the Default Skin is shipped with VLC it has to be licensed according to the GPL, CC SA Scotland was the only fitting one for me)
-All Non-Resizable Windows(Equalizer/Minimal) have got anchors at all 4 corners, Resizable Windows(Main/Playlist) have only got an anchor at the upper left corner

Will movable anchors be included today? When not this is the final version.

Posted: 28 Apr 2006 13:34
by dionoea
OK, i'll include it in VLC trunk then. (Movable anchor won't be included in 0.8.5, even if ipkiss or asmax implements them today)

Thanks a lot for the skin.

Posted: 28 Apr 2006 14:01
by Khamelion
Nothing to critize
Great work. Perfect skin :)