Page 1 of 1

hotkey issues (two hotkeys for same action)

Posted: 31 Jul 2009 15:56
by fleity
hello,

is it possible to set two differnt keys for the same action?

like "p" und " (space)" for play/pause. the reason i want to do this is because i have an IR remote for my pc which sadly has keyboard keys hardcoded to it's buttons.


additionally i would like to control the volume with the left and right arrow keys but without a modifier key like strg, alt or shift they also dont work.


is there a way to solve these to problems?

Re: hotkey issues (two hotkeys for same action)

Posted: 01 Aug 2009 17:36
by VLC_help
With 1.0.x series you can have 2 hotkeys for one action (one normal and one Global).

Hotkey collision in German localization

Posted: 01 Aug 2009 21:56
by blackthorne16
Another hotkey problem that should be solved quite easily:

In the American English version, the hotkey for the menu item "View, Minimal View" is "Ctrl+H".
In the German version, the respective menu item "Ansicht, Minimale Ansicht" is wrongly set to "H".

This creates a collision with the very useful "Subtitle delay up" hotkey (also "H").

I would be grateful if you could correct the German localization in the next version.

Re: hotkey issues (two hotkeys for same action)

Posted: 04 Aug 2009 21:43
by VLC_help
Hotkeys should be same on all VLC languages.

Re: Hotkey collision in German localization

Posted: 26 May 2013 00:47
by johnsnow
Another hotkey problem that should be solved quite easily:

In the American English version, the hotkey for the menu item "View, Minimal View" is "Ctrl+H".
In the German version, the respective menu item "Ansicht, Minimale Ansicht" is wrongly set to "H".

This creates a collision with the very useful "Subtitle delay up" hotkey (also "H").

I would be grateful if you could correct the German localization in the next version.
It's been 4 years now and this problem still has not been fixed.

Image

Re: hotkey issues (two hotkeys for same action)

Posted: 26 May 2013 07:29
by Rémi Denis-Courmont
It's been 4 years and patch is still welcome.

Re: hotkey issues (two hotkeys for same action)

Posted: 26 May 2013 16:07
by Jean-Baptiste Kempf
German translator is wrong, that's all...

Re: hotkey issues (two hotkeys for same action)

Posted: 26 May 2013 21:40
by johnsnow
The en_GB.po contains for example:

Code: Select all

#: modules/gui/qt4/menus.cpp:476 #, fuzzy msgid "Ctrl+H" msgstr "Codec"
and the de.po contains:

Code: Select all

#: modules/gui/qt4/menus.cpp:476 msgid "Ctrl+H" msgstr "Strg+H"
(German for Ctrl is Strg.)

Is it the msgstr that causes the problem, or the fuzzy comment? Some po files contain "Ctrl+H" as msgstr, others an empty string, others just "Ctrl" ..
There's obviously no consistency whatsoever.

And I'm obviously no VLC dev but I'd like to see this trivial problem fixed. If you know how let me know and I'll try to provide a patch...

Re: hotkey issues (two hotkeys for same action)

Posted: 27 May 2013 18:00
by Rémi Denis-Courmont
Fuzzy means the translation was generated by a computer and will be ignored during compilation.

Re: hotkey issues (two hotkeys for same action)

Posted: 27 May 2013 22:03
by johnsnow
So what is the problem? How can any translation file cause a change of hotkeys?

Re: hotkey issues (two hotkeys for same action)

Posted: 27 May 2013 22:04
by Rémi Denis-Courmont
The UI framework parses hot keys in a certain way and if the translation does not follows that way, anything goes.

Re: hotkey issues (two hotkeys for same action)

Posted: 27 May 2013 23:51
by johnsnow
Well there seems to be something wrong with that UI framework then, because this seems fine to me but doesn't work and causes the problem described above:

Code: Select all

#: modules/gui/qt4/menus.cpp:476 msgid "Ctrl+H" msgstr "Strg+H"
I guess that's the reason why a lot of other languages do not have translated hotkeys either. In that case the menu shows the English hotkey text ("Ctrl+...") which is not perfect but at least it doesn't mess with the actual hotkey.

Re: hotkey issues (two hotkeys for same action)

Posted: 28 May 2013 19:37
by Rémi Denis-Courmont
It sure is a limitation of the Qt4 framework, but that is not something the VLC developers can fix. The only "solution" for now consists of reverting to the English spelling of key names.

Re: hotkey issues (two hotkeys for same action)

Posted: 28 May 2013 22:36
by johnsnow
So should I make a patch? If yes, against which version?

Re: hotkey issues (two hotkeys for same action)

Posted: 29 May 2013 19:47
by Rémi Denis-Courmont
I already have a working patch but the powers that be will not let me merge it.

Re: hotkey issues (two hotkeys for same action)

Posted: 14 Jun 2013 16:02
by johnsnow
Why not? It seems to be a trivial change.

Will the fix be in 2.0.8 or .9?

Re: hotkey issues (two hotkeys for same action)

Posted: 27 Aug 2013 23:05
by johnsnow
Half a year later, the problem is still there in 2.0.8 and even in 2.1.0-pre2.