Bug in 094 DefaultIcon for .XSPF File Type

[argb444]

Hi,

For .xspf file association, Windows registry HKCR\VLC.xspf\DefaultIcon contains a bad icon specifier string.

BAD: DefaultIcon=C:\Program Files\VideoLAN\VLC\vlc.exe --started-from-file "%1",0

SHOULD BE: DefaultIcon=C:\Program Files\VideoLAN\VLC\vlc.exe,0

-argb

[Jean-Baptiste Kempf]

I think this works for me.

[VLC_help]

Code: Select all

qvReg->WriteRegistryString( s_path.append( "\\Play\\command" ).c_str(), "", str_temp.append(" --started-from-file \"%1\"" ).c_str() ); qvReg->WriteRegistryString( s_path2.append( "\\DefaultIcon" ).c_str(), "", str_temp.append(",0").c_str() );

That seems wrong, because it appends twice. (from modules\gui\qt4\components\simple_preferences.cpp)

[random]

got correct VLC.xspf DefaultIcon no problem here
"C:\Program Files (x86)\VideoLAN\VLC\vlc.exe",0

[VLC_help]

random: you got correct one by using the association dialog inside VLC?