Page 1 of 1

when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 09 Nov 2009 23:18
by ivanich
After i upgraded to kde 4.3.3 vlc-1.0.3(2) fullscreen doesn't cover the panels anymore. The fullscreen window resizes to the available space on the screen keeping the
panels visible.
Additional info:
https://bugs.kde.org/show_bug.cgi?id=213545
http://bugs.gentoo.org/show_bug.cgi?id=292202

Vlc-1.1.0-git works fine with fullscreen but it has problems with sound.When I switch files in playlist, sometimes I get no sound and messages in console like this:

Code: Select all

[0x8253274] main input debug: reusing aout [0x8254b3c] main audio output debug: looking for audio output module: 4 candidates ALSA lib pcm_dmix.c:1010:(snd_pcm_dmix_open) unable to open slave [0x8254b3c] alsa audio output warning: audio device: default is already in use [0x8254b3c] alsa audio output debug: failed to find a usable alsa configuration [0x8254b3c] oss audio output error: cannot open audio device (/dev/dsp) ALSA lib pcm_dmix.c:1010:(snd_pcm_dmix_open) unable to open slave [0x8254b3c] main audio output debug: using audio output module "dummy" [0x8254b3c] main audio output debug: TIMER module_need() : 1,267 ms - Total 1,267 ms / 1 intvls (Avg 1,267 ms) [0x8254b3c] main audio output debug: output 'mpga' 48000 Hz Stereo frame=1152 samples/1161 bytes [0x8254b3c] main audio output debug: mixer 'fl32' 48000 Hz Stereo frame=1 samples/8 bytes [0x8254b3c] main audio output debug: filter(s) 'fl32'->'mpga' 48000 Hz->48000 Hz Stereo->Stereo [0x86ac864] main audio filter debug: looking for audio filter module: 18 candidates [0x86ac864] main audio filter debug: TIMER module_need() : 0,066 ms - Total 0,066 ms / 1 intvls (Avg 0,066 ms) [0x8254b3c] main audio output error: couldn't find a filter for the conversion [0x8254b3c] main audio output error: couldn't create audio output pipeline [0x8254b3c] main audio output debug: removing module "dummy"

Re: when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 10 Nov 2009 17:11
by Rémi Denis-Courmont
Your sound problem in VLC 1.1 is probably due to a known bug in alsa-lib, which is fixed in the alsa-lib git repository (v1.0.21a-15-g8264b2f).

Re: when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 11 Nov 2009 19:25
by Rémi Denis-Courmont
VLC does request fullscreen mode from the window manager, but then it reparents.
However KWin clears the fullscreen flag when the window is reparented.

I don't have KDE 4.3.3 to check currently, but it should be fixed in VLC 1.0.3-16-g064eca7.

Re: when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 11 Nov 2009 20:51
by ivanich
it should be fixed in VLC 1.0.3-16-g064eca7.
Unfortunately, this does not work with git version from branch: 1.0-bugfix

Re: when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 11 Nov 2009 21:27
by alienbob
I don't have KDE 4.3.3 to check currently, but it should be fixed in VLC 1.0.3-16-g064eca7.
If you could please tell us non-developers how to translate the string "1.0.3-16-g064eca7" to a specific git commit.

Cheers, Eric

Re: when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 13 Nov 2009 17:46
by Rémi Denis-Courmont
That would be because I failed to push my changes :oops: . The correct version is 1.0.3-30-geb31e0f...

Re: when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 13 Nov 2009 23:17
by alienbob
I used that git commit (I still see no correlation between the commit I found in 1.0-debug and "1.0.3-30-geb31e0f" so I hope you will enlighten me how you arrive at that hash value) to patch my vlc-1.0.3 package for Slackware and indeed it fixed the fullscreen issue I was experiencing in KDE 4.3.3.

Eric

Re: when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 14 Nov 2009 10:37
by Rémi Denis-Courmont

Code: Select all

git format-patch 1.0.3..origin/1.0-bugfix
You will need to take patches 29 and 30 into your package. While you're at it, you probably should take patches 1, 13 and 15 too.

Re: when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 28 Nov 2009 13:56
by Murz
Same problem on Kubuntu Karmic & vlc 1.0.2.
Upgrading to vlc 1.0.3 from http://launchpad.net/~c-korn/+archive/vlc didn't solve the problem.
This pach will be applied to newer vlc-1.0.x branches or only to vlc-1.1?

Re: when vlc goes fullscreen panels don't disappear in KDE 4.3.3

Posted: 28 Nov 2009 15:31
by Rémi Denis-Courmont
This fix is only in 1.0-bugfix. The bug does not affect 1.1 in the first place.