some more Libvlc/hotkeys issues

*nix specific usage questions
erwan10
Developer
Developer
Posts: 415
Joined: 02 Nov 2008 23:16

some more Libvlc/hotkeys issues

Postby erwan10 » 02 Nov 2008 23:47

X11 video_output plugin is set up to monitor key/mouse events for any case (either windows created from scratch or widget provided by an existing GUI). This makes it impossible for libvlc programmers to manage their video widgets as they wish.

Question : What about adding an option to switch on/off key/mouse event handling at the plugin level (at least, when not in fullscreen mode) ?

As a test, just by commenting the following X11 line in modules/video_output/x11/xcommon.c, QT4 widget can then display video sent by libvlc and yet respond to key/mouse event from the QT4 architecture.
XSelectInput( p_vout->p_sys->p_display, p_win->base_window,
StructureNotifyMask | KeyPressMask |
ButtonPressMask | ButtonReleaseMask |
PointerMotionMask);
Actually, even the qt4 GUI interface could benefit from it. (Today, on Linux, you cannot access ALT-sthg to reach menus if the mouse is situated on the video widget, because of key/mouse handling at the plugin level)

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: some more Libvlc/hotkeys issues

Postby Jean-Baptiste Kempf » 03 Nov 2008 10:01

You need to process the hotkeys from the vout, since you may not have any interface.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

erwan10
Developer
Developer
Posts: 415
Joined: 02 Nov 2008 23:16

Re: some more Libvlc/hotkeys issues

Postby erwan10 » 03 Nov 2008 14:32

You're right. That's why I was thinking of an option (with three values) like :

--vout-x11-event = none | fullscreen-only | fullsupport

- livlc API developpers could decide which option is best for their need
- those without interface would surely use "fullsupport"
- qt4 interface could be better off with "fullscreen-only" mode, since qt4 interface already manages hotkeys on its own.

Implementing this option (at least for X11) would mean limiting this "XSelectInput" function with if statements. Setting fullsupport mode as default mode would make it painless for anybody.
(I can provide proof-of-concept patch if that can help)


Return to “VLC media player for Linux and friends Troubleshooting”

Who is online

Users browsing this forum: No registered users and 10 guests