NSIS default install type problem - with fix

[VLCfan]

I found some problems with the Nullsoft installer script for Windows. The following options are set to default when they shouldn't be:
- ActiveX plugin
- Delete preferences and cache (isn't applied with the Full profile either)

To fix these problems I edited the vlc.win32.nsi in the following way:
[Line 560] Section /o $Name_Section04 SEC04 ; ActiveX option
[Line 626] Section /o $Name_Section08 SEC08 ; Delete preferences option
[Insert line 627] SectionIn 3 ; Add Delete preferences option to Full profile

I have checked vlc-1.0.1-win32 and vlc-1.0.2-git-20090830-0004-win32 and both have the same problem.

[VLC_help]

Could you please create a patch file and send it to vlc-devel mailing list?

[Jean-Baptiste Kempf]

Why ActiveX shouldn't be default?

[VLCfan]

Could you please create a patch file and send it to vlc-devel mailing list?

ok

Why ActiveX shouldn't be default?

To make the script consistent with the Recommended profile i.e. ActiveX does not exist in the Recommended profile. My intention is to fix the mistakes that I found within the script, not to change the options within the profiles.

[thannoy]

For what I remember, the "delete preferences" had been activated because there were incompatibilities between versions of the plugin cache or the config file. People who didn't cleared them wasn't able to read some files because their new VLC was trying to work with an older version of cache/config.

If the cause which lead to this default activation remains (I don't know if it is the case), then better fix would be to integrate it in the recommendation profile.