VLC 0.9.0 : HTTP Intf & rpn.c : playlist_Control args

[AmiSyl]

hello there,

I found a strange 'bug' in the rpn.c file from the http interface, in the 0.9.0-svn I've got from http://nightlies.videolan.org/build/sid ... 0723-0125/
I'm using Kubuntu 7.04 on an AMD64, and as the vlc build for Feisty (the 7.04) is not working correctly, I had to compile one
I already have experience in this, so it was not a pain, but then a bug appeared
not a really big bug, but annoying when using http-rpn commands

I'm using VLC for the FreePlayer, from the french ISP Free, and at the beginnning (just after a glorious "make install") only the 'play' command was working
it was impossible to stop, pause, even to change video, it was playing the same file (in fact the file with first index in the playlist)
after a short search, I found that the playlist_Control args in rpn.c are not in the good position
for example, at line 506, one can find :

Code: Select all

playlist_Control( p_sys->p_playlist, VLC_TRUE, PLAYLIST_STOP );

which should be

Code: Select all

playlist_Control( p_sys->p_playlist, PLAYLIST_STOP, VLC_TRUE );

as defined by the playlist_Control function (in src/playlist/control.c)

Code: Select all

int playlist_Control( playlist_t * p_playlist, int i_query, vlc_bool_t b_locked, ... )

I had a look in 0.8.6c sources and this vlc_bool_t seems to not exist... maybe a 0.9 feature ?
just reorganizing the 5 lines (stop, pause, next, previous, seek) and recompile did the trick, and now my FreePlayer is back to normal
(well in fact I had to change some html files too, but that's another subject )

[Jean-Baptiste Kempf]

hmmm... Can you send a patch to vlc-devel ?

[AmiSyl]

I'm afraid not :/
if someone else could, here is the patch

Code: Select all

--- rpn-orig.c 2007-03-25 21:35:14.000000000 +0200 +++ rpn.c 2007-07-25 20:45:40.000000000 +0200 @@ -503,22 +503,22 @@ } else if( !strcmp( s, "vlc_stop" ) ) { - playlist_Control( p_sys->p_playlist, VLC_TRUE, PLAYLIST_STOP ); + playlist_Control( p_sys->p_playlist, PLAYLIST_STOP, VLC_TRUE ); msg_Dbg( p_intf, "requested playlist stop" ); } else if( !strcmp( s, "vlc_pause" ) ) { - playlist_Control( p_sys->p_playlist, VLC_TRUE, PLAYLIST_PAUSE ); + playlist_Control( p_sys->p_playlist, PLAYLIST_PAUSE, VLC_TRUE ); msg_Dbg( p_intf, "requested playlist pause" ); } else if( !strcmp( s, "vlc_next" ) ) { - playlist_Control( p_sys->p_playlist, VLC_TRUE, PLAYLIST_SKIP, 1 ); + playlist_Control( p_sys->p_playlist, PLAYLIST_SKIP, VLC_TRUE, 1 ); msg_Dbg( p_intf, "requested playlist next" ); } else if( !strcmp( s, "vlc_previous" ) ) { - playlist_Control( p_sys->p_playlist, VLC_TRUE, PLAYLIST_SKIP, -1 ); + playlist_Control( p_sys->p_playlist, PLAYLIST_SKIP, VLC_TRUE, -1 ); msg_Dbg( p_intf, "requested playlist previous" ); } else if( !strcmp( s, "vlc_seek" ) )

[dionoea]

Fixed (as well as the 3 following playlist_Control() calls) in revision 20890. Thanks a lot.

[Jean-Baptiste Kempf]

Thanks +1.