I made a module for VLC - interested?

Want to help the VideoLAN project? Designers, testers, translators, please come...
This is NOT about GETTING some help.
Forum rules
Please read the forum's rules carefully before posting. This forum should not be used to post VLC usage related questions.
ASantosVal
New Cone
New Cone
Posts: 9
Joined: 18 Jan 2017 12:27

I made a module for VLC - interested?

Postby ASantosVal » 27 Sep 2017 16:19

Hi everyone,

I'm a computer engineer and for my degree's final project I made a module for VLC. It's an Extended Metadata Manager for VLC, which is designed to process multiple file's metadata, to be able to edit them manually on a table, and to fingerprint & search them on acoustId. It's implemented with C++ & Qt (so it works on Windows and Linux). It adds no new dependencies to VLC, it's all done with C++ code and VLC's API. It's also very light, about 15kB code and 300kB on pixmaps (which could be reduced to 5kB by removing/resizing some of them).

Would VideoLAN be interested in adding the module to the official version? If so, I would make any necessary changes.

The module works quite fine, but still has some bugs/improvements I'm working on. My degree's project is finished, so I just want to contribute to the community.

It's a functionality which has been asks by some users: Here is my repository:
https://github.com/ASantosVal/EMM_for_VLC

And here some screenshots:
  1. The module itself:
    Image
  2. The module's menu entry:
    Image
Hope you like it.
Asier Santos

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: I made a module for VLC - interested?

Postby Jean-Baptiste Kempf » 29 Sep 2017 20:05

YES! Like YES, YES!
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

ASantosVal
New Cone
New Cone
Posts: 9
Joined: 18 Jan 2017 12:27

Re: I made a module for VLC - interested?

Postby ASantosVal » 01 Oct 2017 12:20

Great news!

I would like to fix a couple of things during the following weeks, but I think it will be ready really soon. Once that is done, how should I proceed? I read that you usually ask developers to create and send patches, is that still right? Any modifications I should do?

I also read that this kind of in-tree developments are a good chance to get the code reviewed by VideoLAN. How do you usually do these reviews?

I'm really thrilled about this.
Asier Santos

User avatar
InTheWings
Developer
Developer
Posts: 1275
Joined: 07 Aug 2013 13:15
VLC version: crashing
Operating System: Linux
Contact:

Re: I made a module for VLC - interested?

Postby InTheWings » 01 Oct 2017 13:10

We really need to find a way to disable edit/save in UI when the format does not support it
:!: If you want your problem to be solved :
* First read troubleshooting guide VSG:Main
* Always provide verbose LOGS ! (command line or from gui)
* Always check your issue against a developer build from Nightly Build of VLC
* Tell us when your problem is solved !

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: I made a module for VLC - interested?

Postby Jean-Baptiste Kempf » 01 Oct 2017 21:49

Great news!

I would like to fix a couple of things during the following weeks, but I think it will be ready really soon. Once that is done, how should I proceed? I read that you usually ask developers to create and send patches, is that still right? Any modifications I should do?

I also read that this kind of in-tree developments are a good chance to get the code reviewed by VideoLAN. How do you usually do these reviews?

I'm really thrilled about this.
Asier Santos
Yes, send them over, when ready, and we'll review.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: I made a module for VLC - interested?

Postby Jean-Baptiste Kempf » 01 Oct 2017 21:49

We really need to find a way to disable edit/save in UI when the format does not support it
Yep, that too.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.

ASantosVal
New Cone
New Cone
Posts: 9
Joined: 18 Jan 2017 12:27

Re: I made a module for VLC - interested?

Postby ASantosVal » 01 Oct 2017 21:51

We really need to find a way to disable edit/save in UI when the format does not support it
Yep, that too.
Actually, it's supposed to filter the files while loading and only add to the table the supported ones, but I have only tested a few combinations. Have you tried it and found a bug, or was it just a suggestion?

Jean-Baptiste Kempf
Site Administrator
Site Administrator
Posts: 37523
Joined: 22 Jul 2005 15:29
VLC version: 4.0.0-git
Operating System: Linux, Windows, Mac
Location: Cone, France
Contact:

Re: I made a module for VLC - interested?

Postby Jean-Baptiste Kempf » 04 Oct 2017 15:50

We really need to find a way to disable edit/save in UI when the format does not support it
Yep, that too.
Actually, it's supposed to filter the files while loading and only add to the table the supported ones, but I have only tested a few combinations. Have you tried it and found a bug, or was it just a suggestion?
Just a suggestion from experience.
Jean-Baptiste Kempf
http://www.jbkempf.com/ - http://www.jbkempf.com/blog/category/Videolan
VLC media player developer, VideoLAN President and Sites administrator
If you want an answer to your question, just be specific and precise. Don't use Private Messages.


Return to “Contribute and help the VideoLAN project”

Who is online

Users browsing this forum: No registered users and 10 guests