Interface buttons messed up?

[SirGrant]

Hi I just compiled VLC 0.9.2 on Gentoo Linux. I love it except the interface is a tiny bit weird. Here is a screenshot w/ the problem I'm talking about.



Does anyone know why the buttons are showing up like that. How can I fix this. Thanks.

[Jean-Baptiste Kempf]

Duh... Did you modify anything ?
What happens if you widened the interface?

[SirGrant]

No I didn't modify anything. All I did was emerge VLC media player (which compiles it from source) and it came like that. I have not modified the GUI in any way shape or form. If I stretch the window horizontally it still looks like that.

[Jean-Baptiste Kempf]

qt4 version?

[SirGrant]

qt version is 4.3.3

[blackhatbrigade]

After a rebuild of qt and vlc I got to this point too. Mine looks the same.



Anyone have any ideas?

I'm using Gentoo 2008 (2.6.24-r7)
Qt 4.3.3

[Jean-Baptiste Kempf]

OK. Now, all gentoo people have the same issue. Let me try to fix

[blackhatbrigade]

Something that may or may not help. The buttons layout just fine when in full screen mode.

It's just when it's in windowed mode that this happens.

[Jean-Baptiste Kempf]

Can you patch your source ?

[blackhatbrigade]

I've done patches before, but not on gentoo emerge installs... If you tell me what to do I could do it, or I can unmerge vlc and try a manual compile?

either way, I'd at least need a couple pointers.

[Jean-Baptiste Kempf]

Try to add some Qt::AlignBottom in the modules/gui/qt4/components/interface_widgets.cpp in the ControlsWidget constructor.

[blackhatbrigade]

Ok, apparently emerge keeps the source compressed until you actually emerge it and deletes the source after, because I can't find that file. Can I just build from source and do it that way? Or do I need to read some tutorial for how to include the qt support (or any flags needed when running configure?).

Sorry to act the noob. Getting too used to emerge

[blackhatbrigade]

I see the controlswidget constructor and most of the buttons with the problem (slowerButton and fasterButton). Not finding the stop one, but I'm probably not looking hard enough.

I'm not familiar with the Qt interface. Are you suggesting something to the effect of { slowerButton->AlignBottom(); } ?

**Edit:**

Ooops, wrong buttons. prevSectionButton and nextSectionButton right?

This is weird though. I see your discLayout->setSpacing and setMargin. It shouldn't be doing this. Unless I'm just super confused and looking at the wrong place.

[blackhatbrigade]

after line 550 in modules/gui/qt4/components/interface_widgets.cpp I added:

discLayout->setAlignment( Qt::AlignBottom );

Compile went fine but it didn't change how it's laying it out.

I'll keep digging and see if I can figure out if I'm applying this to the right object or not and if something else will work. Maybe you could tell me if I'm even editing the right section of the code.

[blackhatbrigade]

edited line 549 in the same file to:

discLayout->setSpacing( 50 );

(and removed my last line)
just to see if I'm even in the right part of the code. Did not change anything in the gui that I can see. So I'll assume one of three things: 1) I'm not even editing the right place, 2) Something is indeed wrong with Gentoo's Qt compile or 3) I'm not understanding the layout at all.

I'm leaning toward #3, but I'll wait for you to reply before I do anything else.

[blackhatbrigade]

Ok, found the right line.

Line 650

adding: controlButLayout->setAlignment( Qt:AlignBottom ); does not fix the problem.

Changing the spacing to 40 does fix it, but that's probably not a good idea because it sounds like it's working with other distros. I'm not familiar enough with Qt to know how to prevent overlay. Any more ideas? I can fix mine with the spacing value, but I'd rather help figure out how to fix it so it's more portable.

On a side note. It appears the other QHBoxLayout objects are contained in QWidget "frames". Is that how it's done in full screen mode as well? (couldn't find that part of the code) The reason I ask is because full screen is working and I'm wondering if that absence of the QWidget container is causing an issue with Gentoo's version of Qt. Then again, I don't even know what that QWidget "frame" represents.

[SirGrant]

Ok unfortunatly I have zero programming skill so I won't be of much help in fixing the actual program.

Just wanted to give a update though I updated to version 0.9.3 and the problem is still happening.

[Jean-Baptiste Kempf]

No.
QPushButton *nextButton = new QPushButton;

[SirGrant]

on 0.9.4 it still occurring.

[Jean-Baptiste Kempf]

on 0.9.4 it still occurring.

I am sorry, I cannot reproduce...

[SirGrant]

Ok, I'm going to try removing and then reinstalling instead of just upgrading from the previous version. I'll let you know what happens.

[bfx81]

i've exactly the same problem of SirGrant. Tested now vlc 0.9.6 with the same result. Anyway on my other gentoo 64bit machine it's all ok.
The ebuild that install gentoo apply some patches (http://distfiles.gentoo.org/distfiles/v ... 59.tar.bz2 , used from version 0.9.4 to 0.9.6) obviously i can't be sure, but those really seems not related to the gui.
If you want, i've no problem to apply patches, so feel free to send me some code, or better use the gentoo-bug i've open (http://bugs.gentoo.org/show_bug.cgi?id=246116).
Tnx in advance